Address review comments

This adds an additional test to make sure that actions
are dispatched to the appropriate project.

Author: Dexterp37

jbi/runner.py

@@ -246,9 +246,7 @@ def execute_action(
             # is processed (eg. if it spent some time in the DL queue)
             raise IgnoreInvalidRequestError(str(err)) from err
 
-        runner_context = runner_context.update(bug=bug)
-
-        runner_context = runner_context.update(actions=relevant_actions)
+        runner_context = runner_context.update(bug=bug, actions=relevant_actions)
 
         return do_execute_actions(runner_context, bug, relevant_actions)
     except IgnoreInvalidRequestError as exception:
@@ -317,6 +315,10 @@ def do_execute_actions(
             if (
                 project_key := jira_issue["fields"]["project"]["key"]
             ) != action_context.jira.project:
+                # TODO: We're now executing multiple actions for a given bug, we
+                # should probably either not fail and instead report which actions
+                # failed to apply, or execute all the changes as a "transaction" and
+                # roll them back if one of them fails.
                 raise IgnoreInvalidRequestError(
                     f"ignore linked project {project_key!r} (!={action_context.jira.project!r})"
                 )

tests/unit/test_runner.py

@@ -714,3 +714,54 @@ def test_request_triggers_multiple_actions(
     assert len(actions) == len(details)
     assert "devtest" in details
     assert "other" in details
+
+
+def test_request_triggers_multiple_update_actions(
+    webhook_request_factory,
+    mocked_bugzilla,
+    mocked_jira,
+):
+    actions = factories.ActionsFactory(
+        root=[
+            factories.ActionFactory(
+                whiteboard_tag="devtest",
+                bugzilla_user_id="tbd",
+                description="test config",
+                parameters__jira_project_key="JBI",
+            ),
+            factories.ActionFactory(
+                whiteboard_tag="other",
+                bugzilla_user_id="tbd",
+                description="test config",
+                parameters__jira_project_key="DE",
+            ),
+        ]
+    )
+
+    webhook = webhook_request_factory(
+        bug__whiteboard="[devtest][other]",
+        bug__see_also=[
+            "https://mozilla.atlassian.net/browse/JBI-234",
+            "https://mozilla.atlassian.net/browse/DE-567",
+        ],
+    )
+    mocked_bugzilla.get_bug.return_value = webhook.bug
+
+    def side_effect_for_get_issue(issue_key):
+        if issue_key.startswith("JBI-"):
+            return {"fields": {"project": {"key": "JBI"}}}
+        elif issue_key.startswith("DE-"):
+            return {"fields": {"project": {"key": "DE"}}}
+
+        return None
+
+    mocked_jira.get_issue.side_effect = side_effect_for_get_issue
+
+    details = execute_action(request=webhook, actions=actions)
+
+    # Details has the following shape:
+    # {'devtest': {'responses': [..]}, 'other': {'responses': [...]}}
+    assert len(actions) == len(details)
+    assert "devtest" in details
+    assert "other" in details
+    print(details)