Small changes as follow-up of #591 (#601)

* Move bugzilla model tests to test_models

* Delete module docstring and pylint ignore in `test_runner.py`

- if pylint can't enumerate test fixtures, that itself is a clue that
  something is wrong
- The organization of the test directory mirrors that application code
  directory, so it's evident what this module tests

* Update acceptance date of ADR

Author: grahamalama

docs/adrs/002-action-customizaiton.md

@@ -1,7 +1,7 @@
 # Restrict Workflow Customization and Validate Default Action Parameters
 
 - Status: Accepted
-- Date: 2023-06-23
+- Date: 2023-06-27
 
 Tracking issue: [#544](https://github.com/mozilla/jira-bugzilla-integration/issues/544)
 

tests/unit/test_bugzilla.py

@@ -1,7 +1,9 @@
 import pydantic
 import pytest
 
+from jbi.errors import ActionNotFoundError
 from jbi.models import ActionParams, Actions, ActionSteps
+from tests.fixtures.factories import bug_factory
 
 
 @pytest.mark.parametrize("value", [123456, [123456], [12345, 67890], "tbd"])
@@ -13,7 +15,7 @@ def test_valid_bugzilla_user_ids(action_factory, value):
 @pytest.mark.parametrize("value", [None, "[email protected]"])
 def test_invalid_bugzilla_user_ids(action_factory, value):
     with pytest.raises(pydantic.ValidationError):
-        action = action_factory(bugzilla_user_id=value)
+        action_factory(bugzilla_user_id=value)
 
 
 def test_no_actions_fails():
@@ -43,3 +45,84 @@ def test_override_step_configuration_for_single_action_type():
     assert params.steps.new != default_steps.new
     assert params.steps.existing == default_steps.existing
     assert params.steps.comment == default_steps.comment
+
+
+@pytest.mark.parametrize(
+    "see_also,expected",
+    [
+        (None, None),
+        ([], None),
+        (["foo"], None),
+        (["fail:/format"], None),
+        (["foo", "http://jira.net/123"], "123"),
+        (["http://org/123"], None),
+        (["http://jira.com"], None),
+        (["http://mozilla.jira.com/"], None),
+        (["http://mozilla.jira.com/123"], "123"),
+        (["http://mozilla.jira.com/123/"], "123"),
+        (["http://mozilla.jira.com/ticket/123"], "123"),
+        (["http://atlassian.com/ticket/123"], "123"),
+        (["http://mozilla.jira.com/123", "http://mozilla.jira.com/456"], "123"),
+    ],
+)
+def test_extract_see_also(see_also, expected):
+    bug = bug_factory(see_also=see_also)
+    assert bug.extract_from_see_also() == expected
+
+
+@pytest.mark.parametrize(
+    "whiteboard",
+    [
+        "[DevTest-]",
+        "[-DevTest-]",
+        "[-DevTest]",
+        "[DevTest-test]",
+        "[test-DevTest]",
+        "[foo-DevTest-bar]",
+        "[foo-bar-DevTest-foo-bar]",
+        "[example][DevTest]",
+        "[DevTest][example]",
+        "[example][DevTest][example]",
+    ],
+)
+def test_lookup_action_found(whiteboard, actions_example):
+    bug = bug_factory(id=1234, whiteboard=whiteboard)
+    action = bug.lookup_action(actions_example)
+    assert action.whiteboard_tag == "devtest"
+    assert "test config" in action.description
+
+
+@pytest.mark.parametrize(
+    "whiteboard",
+    [
+        "DevTest",
+        "foo DevTest",
+        "DevTest bar",
+        "foo DevTest bar",
+        "[fooDevTest]",
+        "[foo DevTest]",
+        "[DevTestbar]",
+        "[DevTest bar]",
+        "[fooDevTestbar]",
+        "[fooDevTest-bar]",
+        "[foo-DevTestbar]",
+        "[foo] devtest [bar]",
+    ],
+)
+def test_lookup_action_not_found(whiteboard, actions_example):
+    bug = bug_factory(id=1234, whiteboard=whiteboard)
+    with pytest.raises(ActionNotFoundError) as exc_info:
+        bug.lookup_action(actions_example)
+    assert str(exc_info.value) == "devtest"
+
+
+def test_payload_empty_changes_list(webhook_change_status_assignee):
+    webhook_change_status_assignee.event.changes = None
+    assert webhook_change_status_assignee.event.changed_fields() == []
+
+
+def test_payload_changes_list(webhook_change_status_assignee):
+    assert webhook_change_status_assignee.event.changed_fields() == [
+        "status",
+        "assignee",
+    ]

tests/unit/test_models.py

@@ -1,9 +1,4 @@
-"""
-Module for testing jbi/runner.py
-"""
 import logging
-
-# pylint: disable=cannot-enumerate-pytest-fixtures
 from unittest import mock
 
 import pytest