Properly provide project keys to Jira.paginated_projects (#792)

I (wrongly) assumed that this Jira package was [using requests](https://docs.python-requests.org/en/latest/user/quickstart/#passing-parameters-in-urls) to do param parsing, but it's actually using [urllib.parse.urlencode](https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlencode) directly, which doesn't do the magic of turning `{"param": ["foo", "bar"]}` into `?param=foo&param=bar`

Author: grahamalama

jbi/services/jira.py

@@ -121,17 +121,17 @@ def paginated_projects(
                 "``projects_from_cloud`` method is only available for Jira Cloud platform"
             )
 
-        params = {}
+        params = []
 
         if keys is not None:
             if len(keys) > 50:
                 raise ValueError("Up to 50 project keys can be provided.")
-            params["keys"] = list(keys)
+            params = [("keys", key) for key in keys]
 
         if included_archived:
-            params["includeArchived"] = included_archived
+            params.append(("includeArchived", included_archived))
         if expand:
-            params["expand"] = expand
+            params.append(("expand", expand))
         page_url = url or self.resource_url("project/search")
         is_url_absolute = bool(page_url.lower().startswith("http"))
         return self.get(page_url, params=params, absolute=is_url_absolute)
@@ -267,9 +267,14 @@ def _check_project_components(self, action):
         return True
 
     def _all_project_issue_types_exist(self, actions: Actions):
-        paginated_project_response = self.client.paginated_projects(
-            expand="issueTypes", keys=actions.configured_jira_projects_keys
-        )
+        try:
+            paginated_project_response = self.client.paginated_projects(
+                expand="issueTypes", keys=actions.configured_jira_projects_keys
+            )
+        except requests.RequestException:
+            logger.exception("Couldn't fetch projects")
+            return False
+
         projects = paginated_project_response["values"]
         issue_types_by_project = {
             project["key"]: {issue_type["name"] for issue_type in project["issueTypes"]}

tests/unit/services/test_jira.py

@@ -358,3 +358,89 @@ def test_create_jira_issue_returns_errors(
     assert after.message == f"Failed to create issue for Bug {context.bug.id}"
     assert after.levelno == logging.ERROR
     assert after.response == fake_error_data
+
+
+def test_paginated_projects_no_keys(mocked_responses):
+    url = f"{get_settings().jira_base_url}rest/api/2/project/search"
+    mocked_response_data = {"some": "data"}
+    mocked_responses.add(
+        responses.GET,
+        url,
+        status=200,
+        match=[responses.matchers.query_string_matcher(None)],
+        json=mocked_response_data,
+    )
+    resp = jira.get_service().client.paginated_projects()
+    assert resp == mocked_response_data
+
+
+def test_paginated_projects_with_keys(mocked_responses, action_factory):
+    action_factory()
+    url = f"{get_settings().jira_base_url}rest/api/2/project/search"
+    mocked_response_data = {"some": "data"}
+    mocked_responses.add(
+        responses.GET,
+        url,
+        status=200,
+        match=[responses.matchers.query_string_matcher("keys=ABC&keys=DEF")],
+        json=mocked_response_data,
+    )
+    resp = jira.get_service().client.paginated_projects(keys=["ABC", "DEF"])
+    assert resp == mocked_response_data
+
+
+def test_paginated_projects_greater_than_50_keys(mocked_responses):
+    keys = [str(i) for i in range(51)]
+    with pytest.raises(ValueError):
+        jira.get_service().client.paginated_projects(keys=keys)
+
+
+@pytest.mark.parametrize(
+    "project_data, expected_result",
+    [
+        (
+            [
+                {"key": "ABC", "issueTypes": [{"name": "Task"}, {"name": "Bug"}]},
+                {"key": "DEF", "issueTypes": [{"name": "Task"}, {"name": "Bug"}]},
+            ],
+            True,
+        ),
+        (
+            [
+                {"key": "ABC", "issueTypes": [{"name": "Task"}]},
+                {"key": "DEF", "issueTypes": [{"name": "Task"}, {"name": "Bug"}]},
+            ],
+            False,
+        ),
+        (
+            [
+                {"key": "ABC", "issueTypes": [{"name": "Task"}, {"name": "Bug"}]},
+            ],
+            False,
+        ),
+    ],
+)
+def test_all_project_issue_types_exist(
+    mocked_responses, action_factory, project_data, expected_result
+):
+    actions = Actions(
+        root=[
+            action_factory(whiteboard_tag="abc", parameters__jira_project_key="ABC"),
+            action_factory(whiteboard_tag="def", parameters__jira_project_key="DEF"),
+        ]
+    )
+
+    url = f"{get_settings().jira_base_url}rest/api/2/project/search"
+    mocked_responses.add(
+        responses.GET,
+        url,
+        status=200,
+        match=[
+            responses.matchers.query_string_matcher(
+                "keys=ABC&keys=DEF&expand=issueTypes"
+            )
+        ],
+        json={"values": project_data},
+    )
+
+    assert jira.get_service()._all_project_issue_types_exist(actions) == expected_result