Check order of steps

Author: leplatrem

config/config.prod.yaml

@@ -150,16 +150,16 @@
         - add_link_to_jira
         - maybe_assign_jira_user
         - maybe_update_components
-        - maybe_update_issue_resolution
         - maybe_update_issue_status
+        - maybe_update_issue_resolution
         - sync_whiteboard_labels
         - sync_keywords_labels
       existing:
         - update_issue_summary
         - maybe_update_components
         - maybe_assign_jira_user
-        - maybe_update_issue_resolution
         - maybe_update_issue_status
+        - maybe_update_issue_resolution
         - sync_whiteboard_labels
         - sync_keywords_labels
       comment:
@@ -488,16 +488,16 @@
         - add_link_to_jira
         - maybe_assign_jira_user
         - maybe_update_components
-        - maybe_update_issue_resolution
         - maybe_update_issue_status
+        - maybe_update_issue_resolution
         - sync_whiteboard_labels
         - sync_keywords_labels
       existing:
         - update_issue_summary
         - maybe_assign_jira_user
         - maybe_update_components
-        - maybe_update_issue_resolution
         - maybe_update_issue_status
+        - maybe_update_issue_resolution
         - sync_whiteboard_labels
         - sync_keywords_labels
       comment:
@@ -582,13 +582,13 @@
         - add_link_to_bugzilla
         - add_link_to_jira
         - maybe_assign_jira_user
-        - maybe_update_issue_resolution
         - maybe_update_issue_status
+        - maybe_update_issue_resolution
       existing:
         - update_issue_summary
         - maybe_assign_jira_user
-        - maybe_update_issue_resolution
         - maybe_update_issue_status
+        - maybe_update_issue_resolution
       comment:
         - create_comment
     status_map:

jbi/models.py

@@ -59,6 +59,18 @@ def validate_steps(cls, function_names: list[str]):
             raise ValueError(
                 f"The following functions are not available in the `steps` module: {', '.join(invalid_functions)}"
             )
+
+        # Make sure `maybe_update_resolution` comes after `maybe_update_status`.
+        try:
+            idx_resolution = function_names.index("maybe_update_issue_resolution")
+            idx_status = function_names.index("maybe_update_issue_status")
+            assert idx_resolution > idx_status, (
+                "Step `maybe_update_resolution` should be put after `maybe_update_issue_status`"
+            )
+        except ValueError:
+            # One of these 2 steps not listed.
+            pass
+
         return function_names