Skip to content

Commit b783afd

Browse files
committed
Deterministic queryparam order
1 parent 1608af0 commit b783afd

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

jbi/jira/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ def check_jira_all_project_issue_types_exist(self, actions):
522522

523523
try:
524524
paginated_project_response = self.client.paginated_projects(
525-
expand="issueTypes", keys=actions.configured_jira_projects_keys
525+
expand="issueTypes", keys=sorted(actions.configured_jira_projects_keys)
526526
)
527527
except requests.RequestException:
528528
return [

tests/unit/jira/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def test_paginated_projects_with_keys(settings, jira_client, mocked_responses):
8686
responses.GET,
8787
url,
8888
status=200,
89-
match=[responses.matchers.query_string_matcher("keys=ABC&keys=DEF")],
89+
match=[responses.matchers.query_string_matcher("keys=['ABC', 'DEF']")],
9090
json=mocked_response_data,
9191
)
9292
resp = jira_client.paginated_projects(keys=["ABC", "DEF"])

tests/unit/jira/test_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,8 +422,8 @@ def test_all_project_issue_types_exist(
422422
status=200,
423423
match=[
424424
responses.matchers.query_string_matcher(
425-
"keys=ABC&keys=DEF&expand=issueTypes"
426-
)
425+
"keys=['ABC', 'DEF']&expand=issueTypes"
426+
),
427427
],
428428
json={"values": project_data},
429429
)

0 commit comments

Comments
 (0)