Handle exceptions in Jira.get_server_info (#785)

Author: grahamalama

jbi/services/jira.py

@@ -130,9 +130,11 @@ def fetch_visible_projects(self) -> list[dict]:
 
     def check_health(self, actions: Actions) -> ServiceHealth:
         """Check health for Jira Service"""
+        try:
+            is_up = self.client.get_server_info(True) is not None
+        except requests.RequestException:
+            is_up = False
 
-        server_info = self.client.get_server_info(True)
-        is_up = server_info is not None
         health: ServiceHealth = {
             "up": is_up,
             "all_projects_are_visible": is_up and self._all_projects_visible(actions),

tests/unit/services/test_jira.py

@@ -79,9 +79,8 @@ def test_jira_retries_failing_connections_in_health_check(
         body=ConnectionError(),
     )
 
-    with pytest.raises(ConnectionError):
-        jira.get_service().check_health(actions_factory())
-
+    healthcheck = jira.get_service().check_health(actions_factory())
+    assert healthcheck["up"] is False
     assert len(mocked_responses.calls) == 4