Merge pull request #7334 from emilghittasv/improve-playwright-tests

Improve playwright tests

Author: akatsoulas

playwright_tests/pages/ask_a_question/posted_question_pages/questions_page.py

@@ -90,7 +90,7 @@ def __init__(self, page: Page):
             f"//a[@class='tag-name' and normalize-space(text())='{tag_name}']"
         )
         self.delete_tag = lambda tag_name: page.locator(
-            "//a[@class='tag-name' and normalize-space(text())='test']/following-sibling::"
+            f"//a[@class='tag-name' and normalize-space(text())='{tag_name}']/following-sibling::"
             "a[@class='remove']")
 
         """Locators belonging to the post a reply section."""
@@ -336,15 +336,15 @@ def get_question_tag_options(self, is_moderator: bool) -> list[str]:
             .question_tags_options_for_non_moderators)]
 
     def add_text_to_add_a_tag_input_field(self, text: str):
-        self._fill(self.add_a_tag_input_field, text)
+        self._type(self.add_a_tag_input_field, text, 1000)
         self._wait_for_given_timeout(2000)
         self._press_a_key(self.add_a_tag_input_field, "Enter")
 
     def click_on_a_certain_tag(self, tag_name: str, expected_locator):
         self._click(self.tag_by_name(tag_name), expected_locator=expected_locator)
 
     def click_on_tag_remove_button(self, tag_name: str):
-        self._click(self.delete_tag(tag_name))
+        self._click(self.delete_tag(tag_name), expected_locator_to_be_hidden=self.tag(tag_name))
 
     """Actions against the more information section locators."""
     def get_user_agent_information(self) -> str:

playwright_tests/pages/common_elements/common_web_elements.py

@@ -10,7 +10,7 @@ def __init__(self, page: Page):
 
         """Locators belonging to the spam banner."""
         self.scam_banner = page.locator("div#id_scam_alert")
-        self.scam_banner_text = page.locator("div#id_scam_alert p[class='heading']")
+        self.scam_banner_text = page.locator("//div[@id='id_scam_alert']//p[@class='heading']")
         self.learn_more_button = page.locator("div#id_scam_alert").get_by_role("link")
 
         """Locators belonging to the Still need help widget."""
@@ -64,7 +64,7 @@ def __init__(self, page: Page):
     """Actions against the Avoid Spam banner locators."""
     def get_scam_banner_text(self) -> str:
         """Returns the scam banner text."""
-        return self._get_text_of_element(self.scam_banner_text)
+        return self._get_text_of_element(self.scam_banner_text).strip()
 
     """Actions against the Still Need Help widget locators."""
     def click_on_aaq_button(self):

playwright_tests/pages/user_pages/my_profile_edit.py

@@ -50,7 +50,7 @@ def __init__(self, page: Page):
             "p.delete-account-link a")
         self.close_account_username_modal = page.locator("input#delete-profile-confirmation-input")
         self.close_account_username_modal_confirmation_code = page.locator(
-            "//div[@id='delete-profile']//strong")
+            "//div[@data-modal-id='delete-profile']//strong")
         self.close_account_delete_button = page.locator("button#delete-profile-button")
         self.close_modal_button = page.locator("button[class='mzp-c-modal-button-close']")
 

playwright_tests/pages/user_pages/my_profile_page.py

@@ -21,7 +21,7 @@ def __init__(self, page: Page):
         self.private_message_button = page.locator("p.pm").get_by_role("link")
 
         """Locators belonging to the 'Report Abuse' section."""
-        self.report_abuse_panel = page.locator("section#report-abuse-")
+        self.report_abuse_panel = page.locator("//section[@data-modal-id='report-abuse-']")
         self.spam_or_other_unrelated_content_option = page.locator("label").filter(
             has_text="Spam or other unrelated content")
         self.inappropriate_language_or_dialog_option = page.locator("label").filter(
@@ -212,10 +212,6 @@ def click_on_people_directory_link(self):
         """Click on the people directory link."""
         self._click(self.people_directory_info)
 
-    def click_on_element(self, element: ElementHandle):
-        """Click on the given element."""
-        element.click()
-
     def click_my_profile_page_sign_out_button(self, expected_url=None):
         """Click on the profile page sign out button.
 

playwright_tests/pytest.ini

@@ -35,4 +35,4 @@ markers =
     smokeTest: Tests belonging to the smoke test suite.
     userDeletion: Tests belonging to the user deletion suite.
     communityForums: Tests belonging to the community forums suite.
-addopts = --alluredir=./reports/allure_reports --tb=no
+addopts = --alluredir=./reports/allure_reports --video retain-on-failure --tb=no

playwright_tests/test_data/profile_edit.json

@@ -1,5 +1,4 @@
 {
-  "close_account_page": "https://support.allizom.org/en-US/users/close_account",
   "valid_user_edit": {
     "username": "modifiedUsernameAutoTestt",
     "display_name": "Modified display name",

playwright_tests/tests/ask_a_question_tests/product_solutions_page_tests/test_product_solutions_page.py

@@ -29,11 +29,17 @@ def test_featured_articles_redirect(page: Page, is_chromium):
 
     with allure.step("Clicking on all product cards"):
         for card in sumo_pages.contact_support_page.get_all_product_card_titles():
+            redirect_target = utilities.general_test_data['subscription_redirects'].get(card)
             with check, allure.step(f"Clicking on the {card} and verifying that the correct"
                                     f" product solutions page header is displayed"):
                 sumo_pages.contact_support_page.click_on_a_particular_card(card)
-                assert sumo_pages.product_solutions_page.get_product_solutions_heading(
-                ) == card + ProductSolutionsMessages.PAGE_HEADER
+
+                if redirect_target:
+                    assert sumo_pages.product_solutions_page.get_product_solutions_heading(
+                    ) == redirect_target + ProductSolutionsMessages.PAGE_HEADER
+                else:
+                    assert sumo_pages.product_solutions_page.get_product_solutions_heading(
+                    ) == card + ProductSolutionsMessages.PAGE_HEADER
 
             if sumo_pages.product_solutions_page.is_featured_article_section_displayed():
                 for featured_article_card in (sumo_pages.product_solutions_page

playwright_tests/tests/conftest.py

@@ -76,15 +76,13 @@ def pytest_runtest_makereport(item, call) -> None:
 
 
 @pytest.fixture()
-def browser_context_args(browser_context_args, tmpdir_factory: pytest.TempdirFactory):
+def browser_context_args(browser_context_args):
     """
-    Modifying the default browser context to include the location of the browser session screencast
-    and the custom user agent.
+    Modifying the default browser context to include the custom user agent.
     """
     return {
         "user_agent": Utilities.user_agent,
         **browser_context_args,
-        "record_video_dir": tmpdir_factory.mktemp('videos')
     }
 
 

playwright_tests/tests/messaging_system_tests/test_messaging_system.py

@@ -810,20 +810,20 @@ def test_staff_users_can_send_messages_to_both_groups_and_user(page: Page, creat
 def test_removed_group_users_do_not_receive_group_messages(page: Page, create_user_factory):
     utilities = Utilities(page)
     sumo_pages = SumoPages(page)
-    test_user = create_user_factory(groups=["Staff"], permissions=["change_groupprofile"])
-    test_user_two = create_user_factory(
+    test_user = create_user_factory(
         groups=[utilities.user_message_test_data['test_groups'][0]])
-    test_user_three = create_user_factory(
+    test_user_two = create_user_factory(
         groups=[utilities.user_message_test_data['test_groups'][0]])
     message_body = "Test " + utilities.generate_random_number(1, 1000)
     targeted_test_group = utilities.user_message_test_data['test_groups'][0]
 
     with allure.step("Signing in with a staff account and removing a user from the targeted "
                      "group"):
-        utilities.start_existing_session(cookies=test_user)
+        utilities.start_existing_session(
+            session_file_name=utilities.username_extraction_from_email(utilities.staff_user))
         utilities.navigate_to_link(utilities.general_test_data['groups'])
         sumo_pages.user_groups.click_on_a_particular_group(targeted_test_group)
-        sumo_pages.user_group_flow.remove_a_user_from_group(test_user_two["username"])
+        sumo_pages.user_group_flow.remove_a_user_from_group(test_user["username"])
 
     with allure.step("Navigating to the new message page and sending a message to the group"):
         sumo_pages.top_navbar.click_on_inbox_option()
@@ -834,14 +834,14 @@ def test_removed_group_users_do_not_receive_group_messages(page: Page, create_us
             expected_url=SentMessagesPageMessages.SENT_MESSAGES_PAGE_URL
         )
 
-    with allure.step(f"Signing in with {test_user_three['username']} user which is still part of "
+    with allure.step(f"Signing in with {test_user_two['username']} user which is still part of "
                      f"the group and verifying that the message was received"):
-        utilities.start_existing_session(cookies=test_user_three)
+        utilities.start_existing_session(cookies=test_user_two)
         sumo_pages.top_navbar.click_on_inbox_option()
         expect(sumo_pages.inbox_page.inbox_message_by_excerpt(message_body)).to_be_visible()
 
     with allure.step("Verifying that the removed user has not received the group message"):
-        utilities.start_existing_session(cookies=test_user_two)
+        utilities.start_existing_session(cookies=test_user)
         expect(sumo_pages.inbox_page.inbox_message_by_excerpt(message_body)).to_be_hidden()
 
 

playwright_tests/tests/user_deletion_tests/kb/test_user_deletion_and_article_contributions.py

@@ -159,7 +159,7 @@ def test_localization_revisions_are_assigned_to_system_account(page: Page, creat
 def test_reviewed_by_assignment_to_system_account(page: Page, create_user_factory):
     utilities = Utilities(page)
     sumo_pages = SumoPages(page)
-    test_user = create_user_factory()
+    test_user = create_user_factory(permissions=["delete_document"])
     test_user_two = create_user_factory(groups=["Knowledge Base Reviewers"])
 
     with allure.step("Signing in and creating a new kb article"):