Skip to content

Commit e0e428f

Browse files
authored
Merge pull request #6765 from escattone/ignore-invalid-locales-2431
ignore invalid values in `visitors_by_locale`
2 parents 221bb9d + a6638d4 commit e0e428f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

kitsune/sumo/googleanalytics.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,12 @@ def visitors_by_locale(start_date, end_date, verbose=False):
278278
results = {}
279279
for row in run_report(date_range, create_visitors_by_locale_report_request, verbose=verbose):
280280
locale = row.dimension_values[0].value
281-
total_users = int(row.metric_values[0].value)
281+
if locale not in VALID_LOCALES:
282+
continue
283+
try:
284+
total_users = int(row.metric_values[0].value)
285+
except ValueError:
286+
continue
282287
results[locale] = total_users
283288
return results
284289

0 commit comments

Comments
 (0)