Merge pull request #7290 from emilghittasv/playwright-expand-test-coverage

emilghittasv · web-flow · commit e9c8698ba171 · 2026-03-09T09:07:05.000+02:00
Playwright expand test coverage for anti-spam and question reply voting
diff --git a/playwright_tests/flows/ask_a_question_flows/aaq_flows/aaq_flow.py b/playwright_tests/flows/ask_a_question_flows/aaq_flows/aaq_flow.py
@@ -159,8 +159,9 @@ def editing_reply_flow(self, answer_id: str, reply_body: str, submit_reply=True)
             reply_body (str): The new reply body content.
             submit_reply: If the edits should be submitted or not.
         """
-        self.question_page.click_on_reply_more_options_button(answer_id)
-        self.question_page.click_on_edit_this_post_for_a_certain_reply(answer_id)
+        if self.aaq_form_page.form_update_answer_button.is_hidden():
+            self.question_page.click_on_reply_more_options_button(answer_id)
+            self.question_page.click_on_edit_this_post_for_a_certain_reply(answer_id)
 
         self.aaq_form_page.clear_the_question_body_textarea_field()
         self.aaq_form_page.add_text_to_aaq_textarea_field(reply_body)
@@ -184,7 +185,7 @@ def delete_question_reply(self, answer_id: str, delete_reply: bool):
 
     @retry_on_502
     def post_question_reply_flow(self, repliant_username: str, reply='', submit_reply=True,
-                                 quoted_reply=False, reply_for_id='') -> str:
+                                 quoted_reply=False, reply_for_id='', fetch_id=True) -> str:
         """
         Flow for posting a question reply.
         Args:
@@ -206,7 +207,7 @@ def post_question_reply_flow(self, repliant_username: str, reply='', submit_repl
             self.question_page.add_text_to_post_a_reply_textarea(reply)
 
         if submit_reply:
-            return self.question_page.click_on_post_reply_button(repliant_username)
+            return self.question_page.click_on_post_reply_button(repliant_username, fetch_id)
 
     def report_question_abuse(self, answer_id: str, text=''):
         """
diff --git a/playwright_tests/pages/ask_a_question/posted_question_pages/questions_page.py b/playwright_tests/pages/ask_a_question/posted_question_pages/questions_page.py
@@ -234,8 +234,6 @@ def __init__(self, page: Page):
     def get_text_of_spam_marked_banner(self) -> str:
         return self._get_text_of_element(self.reply_flagged_as_spam_banner)
 
-    def is_spam_marked_banner_displayed(self) -> bool:
-        return self._is_element_visible(self.reply_flagged_as_spam_banner)
 
     """Actions against the report abuse section locators."""
     def click_abuse_modal_close_button(self):
@@ -423,10 +421,16 @@ def get_blockquote_reply_text(self, reply_id: str) -> str:
     def get_posted_reply_modified_by_text(self, reply_id: str) -> str:
         return self._get_text_of_element(self.modified_by_text(reply_id))
 
-    def click_on_post_reply_button(self, repliant_username) -> str:
+    def click_on_post_reply_button(self, repliant_username, fetch_id: bool) -> str:
+        """Post the question reply.
+        Args:
+            repliant_username (str): The username of the repliant. Acts as a wait.
+            fetch_id (bool): If we should return the question reply id or not.
+        """
         self._click(self.post_reply_button,
                     expected_locator=self.repliant_username(repliant_username))
-        return self._get_element_attribute_value(self.answer_by_username(repliant_username), "id")
+        if fetch_id:
+            return self._get_element_attribute_value(self.answer_by_username(repliant_username), "id")
 
     """Actions against the question tools section locators."""
     def get_thread_locked_text(self) -> str:
diff --git a/playwright_tests/tests/ask_a_question_tests/aaq_tests/test_anti_spam_measures.py b/playwright_tests/tests/ask_a_question_tests/aaq_tests/test_anti_spam_measures.py
@@ -1,13 +1,15 @@
+import random
 import allure
 import pytest
-from playwright.sync_api import Page
+from playwright.sync_api import Page, expect
 from pytest_check import check
 from playwright_tests.core.utilities import Utilities
 from playwright_tests.messages.ask_a_question_messages.AAQ_messages.question_page_messages import (
     QuestionPageMessages,
 )
 from playwright_tests.messages.common_elements_messages import CommonElementsMessages
 from playwright_tests.pages.sumo_pages import SumoPages
+from kitsune.settings import TRUSTED_GROUPS
 
 
 # C946237
@@ -51,16 +53,16 @@ def test_anti_spam_banner(page: Page, user_type, create_user_factory):
             CommonElementsMessages.AVOID_SCAM_BANNER_TEXT)
 
 
-# C946274
+# C946275
 @pytest.mark.smokeTest
 @pytest.mark.antiSpamTests
-def test_valid_tld_in_question_comment(page: Page, create_user_factory):
+def test_spam_content_is_auto_flagged(page: Page, create_user_factory):
     sumo_pages = SumoPages(page)
     utilities = Utilities(page)
-    invalid_tld = "dom.ipc.processCount"
-    valid_tld = "layout.display-list.retain.chrome"
     test_user = create_user_factory(groups=["Forum Moderators"])
     test_user_two = create_user_factory()
+    spam_content = ['https://www.example.com', 'layout.display-list.retain.chrome',
+                    '800, 888, 877, 866, 855, 844, or 833', '+1 212-555-1234']
 
     with allure.step("Signing in with a Forum Moderator account and creating an AAQ question"):
         utilities.start_existing_session(cookies=test_user)
@@ -74,38 +76,150 @@ def test_valid_tld_in_question_comment(page: Page, create_user_factory):
             expected_locator=sumo_pages.question_page.questions_header
         )
 
-    with allure.step("Signing in with an account that doesn't have the bypass ratelimit "
-                     "permission"):
-        utilities.start_existing_session(cookies=test_user_two)
+    for content in spam_content:
+        with allure.step("Signing in with an account that doesn't have the bypass ratelimit "
+                         "permission"):
+            utilities.start_existing_session(cookies=test_user_two)
 
-    with allure.step("Leaving a comment with an invalid TLD"):
-        reply_one = sumo_pages.aaq_flow.post_question_reply_flow(
-            repliant_username=test_user_two["username"], reply=invalid_tld
-        )
+        with allure.step(f"Leaving a comment with {content} spam content"):
+            sumo_pages.aaq_flow.post_question_reply_flow(
+                repliant_username=test_user_two["username"], reply=content, fetch_id=False
+            )
+
+        with check, allure.step("Verifying that the spam banner is successfully displayed"):
+            assert (QuestionPageMessages.SPAM_FLAGGED_REPLY == sumo_pages.question_page.
+                    get_text_of_spam_marked_banner())
+
+        with check, allure.step(f"Verifying that the comment is marked as spam"):
+            assert not sumo_pages.question_page.is_reply_with_content_displayed(content)
+
+        with check, allure.step("Signing out and verifying that the reply is not displayed"):
+            utilities.delete_cookies()
+            assert not sumo_pages.question_page.is_reply_with_content_displayed(content)
+
+        with check, allure.step("Signing in with an admin account and verifying that the Marked as "
+                                "spam reply is visible"):
+            utilities.start_existing_session(cookies=test_user)
+            assert sumo_pages.question_page.is_reply_with_content_displayed(content)
 
-    with check, allure.step("Verifying that the spam banner is not displayed"):
-        assert not sumo_pages.question_page.is_spam_marked_banner_displayed()
 
-    with check, allure.step("Verifying that the invalid TLD comment is not marked as spam"):
-        assert sumo_pages.question_page.is_reply_displayed(reply_one)
+# C946276
+@pytest.mark.antiSpamTests
+def test_valid_prefs_and_internal_links_are_not_flagged_as_spam(page: Page, create_user_factory):
+    sumo_pages = SumoPages(page)
+    utilities = Utilities(page)
+    test_user = create_user_factory(groups=["Forum Moderators"])
+    test_user_two = create_user_factory()
+    test_content = ['https://support.mozilla.org', 'dom.ipc.processCount']
 
-    with allure.step("Leaving a comment with a valid TLD"):
-        sumo_pages.aaq_flow.post_question_reply_flow(
-            repliant_username=test_user_two["username"], reply=valid_tld
+    with allure.step("Signing in with a Forum Moderator account and creating an AAQ question"):
+        utilities.start_existing_session(cookies=test_user)
+
+        utilities.navigate_to_link(utilities.aaq_question_test_data["products_aaq_url"]["Firefox"])
+        sumo_pages.aaq_flow.submit_an_aaq_question(
+            subject=utilities.aaq_question_test_data["valid_firefox_question"]["subject"],
+            topic_name=sumo_pages.aaq_form_page.get_aaq_form_topic_options()[0],
+            body=utilities.aaq_question_test_data["valid_firefox_question"]["question_body"],
+            attach_image=False,
+            expected_locator=sumo_pages.question_page.questions_header
         )
 
-    with check, allure.step("Verifying that the spam banner is successfully displayed"):
-        assert (QuestionPageMessages.SPAM_FLAGGED_REPLY == sumo_pages.question_page.
-                get_text_of_spam_marked_banner())
+    for content in test_content:
+        with allure.step("Signing in with an account that doesn't have the bypass ratelimit "
+                         "permission"):
+            utilities.start_existing_session(cookies=test_user_two)
 
-    with check, allure.step("Verifying that the valid TLD comment is marked as spam"):
-        assert not sumo_pages.question_page.is_reply_with_content_displayed(valid_tld)
+        with allure.step(f"Leaving a comment with {content} spam content"):
+            reply_id = sumo_pages.aaq_flow.post_question_reply_flow(
+                repliant_username=test_user_two["username"], reply=content,
+            )
 
-    with check, allure.step("Signing out and verifying that the reply is not displayed"):
-        utilities.delete_cookies()
-        assert not sumo_pages.question_page.is_reply_with_content_displayed(valid_tld)
+        with check, allure.step("Verifying that the spam banner is not displayed"):
+            expect(sumo_pages.question_page.reply_flagged_as_spam_banner).to_be_hidden()
+
+        with check, allure.step(f"Verifying that the valid pref value comment is displayed"):
+            assert sumo_pages.question_page.is_reply_displayed(reply_id)
+
+        with check, allure.step("Signing out and verifying that the reply is displayed"):
+            utilities.delete_cookies()
+            assert sumo_pages.question_page.is_reply_displayed(reply_id)
+
+
+# C1296001, C3395616
+@pytest.mark.antiSpamTests
+def test_question_owner_is_exempted_for_spam_auto_flag(page: Page, create_user_factory):
+    utilities = Utilities(page)
+    sumo_pages = SumoPages(page)
+    spam_content = ['https://www.example.com', 'layout.display-list.retain.chrome',
+                    '800, 888, 877, 866, 855, 844, or 833', '+1 212-555-1234']
+    test_user = create_user_factory()
+
+    with allure.step("Signing in creating an AAQ question"):
+        utilities.start_existing_session(cookies=test_user)
 
-    with check, allure.step("Signing in with an admin account and verifying that the Marked as "
-                            "spam reply is visible"):
+    utilities.navigate_to_link(
+        utilities.aaq_question_test_data["products_aaq_url"]["Firefox"])
+    sumo_pages.aaq_flow.submit_an_aaq_question(
+        subject=utilities.aaq_question_test_data["valid_firefox_question"]["subject"],
+        topic_name=sumo_pages.aaq_form_page.get_aaq_form_topic_options()[0],
+        body=utilities.
+             aaq_question_test_data["valid_firefox_question"]["question_body"] + spam_content[1],
+        attach_image=False,
+        expected_locator=sumo_pages.question_page.questions_header
+    )
+
+    for content in spam_content:
+        with allure.step(f"Leaving a comment with a spam comment"):
+            reply_id = sumo_pages.aaq_flow.post_question_reply_flow(
+                repliant_username=test_user["username"], reply=content
+            )
+
+        with check, allure.step("Verifying that the spam banner is not displayed"):
+            expect(sumo_pages.question_page.reply_flagged_as_spam_banner).to_be_hidden()
+
+        with check, allure.step(f"Verifying that the comment is displayed"):
+            assert sumo_pages.question_page.is_reply_displayed(reply_id)
+
+
+# C3395573, C3395578
+@pytest.mark.antiSpamTests
+@pytest.mark.parametrize("trusted_user_config", [
+    {"groups": [random.choice(TRUSTED_GROUPS)]},
+    {"permissions": ["can_moderate"]}
+])
+def test_trusted_contributors_are_exempted_from_spam_check(page: Page, create_user_factory,
+                                                           trusted_user_config):
+    utilities = Utilities(page)
+    sumo_pages = SumoPages(page)
+    test_user = create_user_factory()
+    trusted_group_user = create_user_factory(**trusted_user_config)
+    spam_content = ['https://www.example.com', 'layout.display-list.retain.chrome',
+                    '800, 888, 877, 866, 855, 844, or 833', '+1 212-555-1234']
+
+    with allure.step("Signing in creating an AAQ question"):
         utilities.start_existing_session(cookies=test_user)
-        assert sumo_pages.question_page.is_reply_with_content_displayed(valid_tld)
+
+    utilities.navigate_to_link(
+        utilities.aaq_question_test_data["products_aaq_url"]["Firefox"])
+    sumo_pages.aaq_flow.submit_an_aaq_question(
+        subject=utilities.aaq_question_test_data["valid_firefox_question"]["subject"],
+        topic_name=sumo_pages.aaq_form_page.get_aaq_form_topic_options()[0],
+        body=utilities.aaq_question_test_data["valid_firefox_question"]["question_body"],
+        attach_image=False,
+        expected_locator=sumo_pages.question_page.questions_header
+    )
+
+    for content in spam_content:
+        with allure.step("Signing in with a trusted user"):
+            utilities.start_existing_session(cookies=trusted_group_user)
+
+        with allure.step(f"Leaving a comment with a spam comment"):
+            reply_id = sumo_pages.aaq_flow.post_question_reply_flow(
+                repliant_username=trusted_group_user["username"], reply=content
+            )
+
+        with check, allure.step("Verifying that the spam banner is not displayed"):
+            expect(sumo_pages.question_page.reply_flagged_as_spam_banner).to_be_hidden()
+
+        with check, allure.step(f"Verifying that the comment is displayed"):
+            assert sumo_pages.question_page.is_reply_displayed(reply_id)
diff --git a/playwright_tests/tests/ask_a_question_tests/aaq_tests/test_posted_questions.py b/playwright_tests/tests/ask_a_question_tests/aaq_tests/test_posted_questions.py
@@ -1388,9 +1388,31 @@ def test_quote_reply_functionality_signed_out(page: Page, create_user_factory):
         expect(sumo_pages.question_page.post_a_reply_textarea).to_be_visible()
 
 
-# T5696770
-@pytest.mark.skip
-# Currently fails due to https://github.com/mozilla/sumo/issues/1216
+# C3186666
+@pytest.mark.postedQuestions
+def test_answer_voting_is_not_available_for_signed_out_users(page: Page, create_user_factory):
+    utilities = Utilities(page)
+    sumo_pages = SumoPages(page)
+    test_user = create_user_factory()
+
+    with allure.step("Signing in with a simple user account and posting a Firefox product "
+                     "question"):
+        post_firefox_product_question_flow(page, test_user)
+    sumo_pages.question_page.get_question_id()
+
+    with allure.step("Posting a reply to the question"):
+        reply_id = sumo_pages.aaq_flow.post_question_reply_flow(
+            test_user['username'],
+            utilities.aaq_question_test_data['valid_firefox_question']['question_reply'])
+
+    with allure.step("Signing out and verifying that logged out users are not able to vote "
+                     "question replies"):
+        utilities.delete_cookies()
+        expect(sumo_pages.question_page.reply_vote_section(reply_id)).to_be_hidden()
+
+
+# C937575
+@pytest.mark.postedQuestions
 def test_question_reply_votes(page: Page, create_user_factory):
     utilities = Utilities(page)
     sumo_pages = SumoPages(page)
@@ -1406,10 +1428,9 @@ def test_question_reply_votes(page: Page, create_user_factory):
     sumo_pages.question_page.get_question_id()
 
     with allure.step("Posting a reply to the question"):
-        sumo_pages.question_page.add_text_to_post_a_reply_textarea(
-            utilities.aaq_question_test_data['valid_firefox_question']['question_reply']
-        )
-        reply_id = sumo_pages.question_page.click_on_post_reply_button(test_user["username"])
+        reply_id = sumo_pages.aaq_flow.post_question_reply_flow(
+            test_user['username'],
+            utilities.aaq_question_test_data['valid_firefox_question']['question_reply'])
 
     with allure.step("Verifying the vote reply is not available for self posted questions"):
         expect(sumo_pages.question_page.reply_vote_section(reply_id)).to_be_hidden()
@@ -1447,49 +1468,6 @@ def test_question_reply_votes(page: Page, create_user_factory):
         expect(sumo_pages.question_page.reply_vote_thumbs_down(reply_id)
                ).to_have_attribute(name="disabled",value="")
 
-    with check, allure.step("Refreshing the page and verifying that the correct number of "
-                            "thumbs up votes is displayed"):
-        utilities.refresh_page()
-        assert (int(sumo_pages.question_page.
-                    get_helpful_count(reply_id)) == number_of_thumbs_up_votes)
-
-    with check, allure.step("Verifying that the correct number of thumbs down votes is "
-                            "displayed"):
-        assert (int(sumo_pages.question_page.
-                    get_not_helpful_count(reply_id)) == number_of_thumbs_down_votes)
-
-    with allure.step("Deleting the user session and clicking on the 'thumbs up' button"):
-        utilities.delete_cookies()
-        sumo_pages.question_page.click_reply_vote_thumbs_up_button(reply_id)
-        number_of_thumbs_up_votes += 1
-
-    with check, allure.step("Refreshing the page and verifying that the correct number of "
-                            "thumbs up votes is displayed"):
-        utilities.refresh_page()
-        assert (int(sumo_pages.question_page.
-                    get_helpful_count(reply_id)) == number_of_thumbs_up_votes)
-
-    with check, allure.step("Verifying that the correct number of thumbs down votes is "
-                            "displayed"):
-        assert (int(sumo_pages.question_page.
-                    get_not_helpful_count(reply_id)) == number_of_thumbs_down_votes)
-
-    with allure.step("Verifying that the thumbs up button contains the disabled attribute"):
-        expect(sumo_pages.question_page.reply_vote_thumbs_up(reply_id)
-               ).to_have_attribute(name="disabled", value="")
-
-    with allure.step("Verifying that the thumbs down button contains the disabled attribute"):
-        expect(sumo_pages.question_page.reply_vote_thumbs_down(reply_id)
-               ).to_have_attribute(name="disabled", value="")
-
-    with check, allure.step("Refreshing the page and verifying that the correct number of "
-                            "thumbs up votes is displayed"):
-        utilities.refresh_page()
-        assert (int(sumo_pages.question_page.
-                    get_helpful_count(reply_id)) == number_of_thumbs_up_votes)
-        assert (int(sumo_pages.question_page.
-                    get_not_helpful_count(reply_id)) == number_of_thumbs_down_votes)
-
     with allure.step("Signing in with a Forum Moderator account and clicking on the vote down "
                      "button"):
         utilities.start_existing_session(cookies=test_user_three)
@@ -1716,10 +1694,10 @@ def test_common_responses(page: Page, create_user_factory):
         sumo_pages.question_page.click_on_common_responses_insert_response_button()
         try:
             reply_id = sumo_pages.question_page.click_on_post_reply_button(
-                test_user_two["username"])
+                test_user_two["username"], fetch_id=True)
         except TimeoutError:
             reply_id = sumo_pages.question_page.click_on_post_reply_button(
-                test_user_two["username"])
+                test_user_two["username"], fetch_id=True)
         assert sumo_pages.question_page.get_text_content_of_reply(
             reply_id).strip() in response.strip()
 
diff --git a/playwright_tests/tests/ask_a_question_tests/community_forums/test_community_forums_by_product.py b/playwright_tests/tests/ask_a_question_tests/community_forums/test_community_forums_by_product.py
@@ -10,7 +10,7 @@
 from playwright_tests.pages.sumo_pages import SumoPages
 
 
-# C3040845
+# C3040845. C891278, C891277
 @pytest.mark.communityForums
 def test_product_community_cards_are_redirecting_to_the_correct_forum(page: Page):
     sumo_pages = SumoPages(page)
