Skip to content

Commit 509676c

Browse files
committed
Fix url encoding using escaped space characters
* urllib.parse.urlencode quotes strings using `quote_plus` * this patch uses urllib.parse.quote instead for compatibility with some providers
1 parent 821de3d commit 509676c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mozilla_django_oidc/middleware.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
add_state_and_nonce_to_session,
1515
import_from_settings)
1616

17-
from urllib.parse import urlencode
17+
from urllib.parse import quote, urlencode
1818

1919
try:
2020
# Python 3.7 or later
@@ -160,7 +160,7 @@ def process_request(self, request):
160160

161161
request.session['oidc_login_next'] = request.get_full_path()
162162

163-
query = urlencode(params)
163+
query = urlencode(params, quote_via=quote)
164164
redirect_url = '{url}?{query}'.format(url=auth_url, query=query)
165165
if request.headers.get('x-requested-with') == 'XMLHttpRequest':
166166
# Almost all XHR request handling in client-side code struggles

0 commit comments

Comments
 (0)