Merge pull request #20389 from calixteman/bug1995579

[Editor] Make sure the left (resp. right) corner of the popup is visible when in LTR (resp. RTL) (bug 1995579)

Author: calixteman

web/comment_manager.js

@@ -1234,15 +1234,26 @@ class CommentPopup {
     if (!correctPosition) {
       this.#editor.commentPopupPosition = [x, y];
     } else {
-      const widthRatio =
-        this._popupWidth / this.#editor.parentBoundingClientRect.width;
+      const parentRect = this.#editor.parentBoundingClientRect;
+      const widthRatio = this._popupWidth / parentRect.width;
       if (
         (this.#isLTR && x + widthRatio > 1) ||
         (!this.#isLTR && x - widthRatio >= 0)
       ) {
         const buttonWidth = this.#editor.commentButtonWidth;
         x -= widthRatio - buttonWidth;
       }
+      const margin = 0.01;
+      if (this.#isLTR) {
+        x = Math.max(x, -parentRect.x / parentRect.width + margin);
+      } else {
+        x = Math.min(
+          x,
+          (window.innerWidth - parentRect.x) / parentRect.width -
+            widthRatio -
+            margin
+        );
+      }
     }
     this.#posX = x;
     this.#posY = y;