Skip to content

Commit 4559963

Browse files
committed
bug 1877836 - Remove GeckoView Streaming Telemetry
And the GVST-specific easing of the duplicate check.
1 parent 96f0334 commit 4559963

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

probe_scraper/glean_checks.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,9 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails):
137137
if metric["history"][-1]["dates"]["last"] == last_timestamp:
138138
metric_sources.setdefault(metric_name, []).append(dependency)
139139

140-
duplicate_sources = {}
141-
for (k, v) in metric_sources.items():
142-
# Exempt cases when one of the sources is Geckoview Streaming to
143-
# avoid false positive duplication accross app channels.
144-
v = [dep for dep in v if "engine-gecko" not in dep]
145-
if len(v) > 1:
146-
duplicate_sources[k] = v
140+
duplicate_sources = dict(
141+
(k, v) for (k, v) in metric_sources.items() if len(v) > 1
142+
)
147143

148144
if not len(duplicate_sources):
149145
continue

repositories.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ libraries:
7474
7575
7676
url: https://github.com/mozilla/gecko-dev
77-
metrics_files:
78-
- toolkit/components/telemetry/geckoview/streaming/metrics.yaml
77+
metrics_files: []
7978
variants:
8079
- v1_name: engine-gecko
8180
branch: release

0 commit comments

Comments
 (0)