Skip to content

Commit 4ff817f

Browse files
committed
Remove engine-gecko now that it is empty
1 parent d556e6c commit 4ff817f

File tree

2 files changed

+0
-40
lines changed

2 files changed

+0
-40
lines changed

probe_scraper/glean_checks.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -139,19 +139,6 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails):
139139

140140
duplicate_sources = {}
141141
for k, v in metric_sources.items():
142-
# Exempt cases when one of the sources is Geckoview Streaming to
143-
# avoid false positive duplication accross app channels.
144-
# Temporarily exempt cases when one of the sources is server compat library
145-
# to avoid raising alarm for metrics defined in fxa's custom ping.
146-
v = [
147-
dep
148-
for dep in v
149-
if (
150-
"engine-gecko" not in dep
151-
and "glean-server-metrics-compat" not in dep
152-
)
153-
]
154-
155142
if len(v) > 1:
156143
duplicate_sources[k] = v
157144

repositories.yaml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -93,23 +93,6 @@ libraries:
9393
variants:
9494
- v1_name: sync
9595
dependency_name: org.mozilla.appservices:syncmanager
96-
- library_name: engine-gecko
97-
description: GeckoView metrics
98-
notification_emails:
99-
100-
101-
102-
url: https://github.com/mozilla/gecko-dev
103-
metrics_files: []
104-
variants:
105-
- v1_name: engine-gecko
106-
branch: release
107-
dependency_name: org.mozilla.components:browser-engine-gecko
108-
- v1_name: engine-gecko-beta
109-
branch: beta
110-
dependency_name: org.mozilla.components:browser-engine-gecko-beta
111-
- v1_name: engine-gecko-nightly
112-
dependency_name: org.mozilla.components:browser-engine-gecko-nightly
11396

11497
- library_name: logins-store
11598
description: >-
@@ -722,38 +705,28 @@ applications:
722705
- v1_name: firefox-android-release
723706
app_id: org.mozilla.firefox
724707
app_channel: release
725-
additional_dependencies:
726-
- org.mozilla.components:browser-engine-gecko
727708
description: >-
728709
Release channel of Firefox for Android.
729710
- v1_name: firefox-android-beta
730711
app_id: org.mozilla.firefox_beta
731712
app_channel: beta
732-
additional_dependencies:
733-
- org.mozilla.components:browser-engine-gecko-beta
734713
description: >-
735714
Beta channel of Firefox for Android.
736715
- v1_name: fenix
737716
app_id: org.mozilla.fenix
738717
app_channel: nightly
739-
additional_dependencies:
740-
- org.mozilla.components:browser-engine-gecko-beta
741718
description: >-
742719
Nightly channel of Firefox for Android.
743720
Prior to June 2020, this app_id was used for the beta channel
744721
of Firefox Preview.
745722
- v1_name: fenix-nightly
746723
app_id: org.mozilla.fenix.nightly
747724
app_channel: nightly
748-
additional_dependencies:
749-
- org.mozilla.components:browser-engine-gecko-nightly
750725
description: >-
751726
Nightly channel of Firefox Preview.
752727
- v1_name: firefox-android-nightly
753728
app_id: org.mozilla.fennec.aurora
754729
app_channel: nightly
755-
additional_dependencies:
756-
- org.mozilla.components:browser-engine-gecko-beta
757730
description: >-
758731
Nightly channel of Firefox for Android users migrated to Fenix;
759732
delisted in June 2020.

0 commit comments

Comments
 (0)