Remove skip metric hacks

Fixes #697

Author: badboy

probe_scraper/glean_checks.py

@@ -16,14 +16,6 @@
 
 from .scrapers.git_scraper import Commit
 
-# Ugly hack to skip certain metrics which we know aren't duplicated,
-# but show up duplicated due to them being moved from one
-# to the other application/library.
-SKIP_METRICS = {
-    "gecko.version": ["gecko", "pine", "firefox-desktop"],
-    "gecko.build_id": ["gecko", "pine", "firefox-desktop"],
-}
-
 
 def _metric_sort_key(metric: Dict[str, Any]):
     return (
@@ -151,11 +143,6 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails):
             # avoid false positive duplication accross app channels.
             v = [dep for dep in v if "engine-gecko" not in dep]
 
-            if k in SKIP_METRICS.keys():
-                potential_deps = SKIP_METRICS[k]
-                if any([dep for dep in potential_deps if dep in v]):
-                    continue
-
             if len(v) > 1:
                 duplicate_sources[k] = v