Skip to content

Remove dupe-metric hack #697

New issue
New issue
Open
#725
Open
Remove dupe-metric hack#697
#725
@badboy

Description

@badboy
badboy
opened on Feb 20, 2024

I added a hack to get firefox-desktop to work properly again:

probe-scraper/probe_scraper/glean_checks.py

Lines 19 to 25 in 5717fce

# Ugly hack to skip certain metrics which we know aren't duplicated,
# but show up duplicated due to them being moved from one
# to the other application/library.
SKIP_METRICS = {
"gecko.version": ["gecko", "pine", "firefox-desktop"],
"gecko.build_id": ["gecko", "pine", "firefox-desktop"],
}

We should find a way that this is not necessary.
It shouldn't. The metric is moved from the app to the library.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions