Possible problem with 1.9.0 WrapFactory

[ramire01]

Hello,

It looks like 1.9.0 does not call the wrap function. In 1.8.1, the log message appears many times, but it never appears for 1.9.0 or 1.9.1 :

public class CustomContextFactory extends ContextFactory {
    private static final Logger LOG = LoggerFactory.getLogger(CustomContextFactory.class);
    
    @Override
    protected void onContextCreated(Context cx) {
        cx.setLanguageVersion(Context.VERSION_ES6);
        cx.getWrapFactory().setJavaPrimitiveWrap(false);
        
        cx.setWrapFactory(new CustomWrapFactory());
        cx.setInstructionObserverThreshold(10000);
    }
...
    class CustomWrapFactory extends WrapFactory {
        public Object wrap(Context cx, Scriptable scope, Object obj, Class<?> staticType) {
            LOG.error("CustomWrapFactory " + obj);

            if (obj == null) {
                return null;
            } else if (obj instanceof String || obj instanceof Number || obj instanceof Boolean) {
                return obj;
            } else if (obj instanceof Character) {
                char[] a = {((Character) obj).charValue()};
                return new String(a);
            } else if (obj instanceof java.util.Date) {
                long time = ((java.util.Date) obj).getTime();
                try {
                    return cx.newObject(scope, "Date", new Object[] { time });
                } catch (Exception e) {
                    e.printStackTrace();
                }
            }

            return super.wrap(cx, scope, obj, staticType);
        }
    }
}


       public static void main(String[] args) throws Exception, IOException {
           CustomContextFactory fac = new CustomContextFactory();
           ContextFactory.initGlobal(fac);
           ...
       }

[aardvark179]

Is this another case of #2265?

[ramire01]

Yes, using TypeInfo in the wrap() method fixed it. Thank you.

[aardvark179]

No problem.