Nightly auto-update (128.0.20240525050247)

Firefox Sync Engineering · Firefox Sync Engineering · commit 3b8bfec37b67 · 2024-05-25T08:02:50.000Z
diff --git a/Package.swift b/Package.swift
@@ -1,13 +1,13 @@
 // swift-tools-version:5.4
 import PackageDescription
 
-let checksum = "7f68f118bbd85cf5e06bf88218cd354b70a42a7c6d7251d02f4c978c950ac044"
-let version = "128.0.20240523050311"
-let url = "https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/project.application-services.v2.swift.128.20240523050311/artifacts/public/build/MozillaRustComponents.xcframework.zip"
+let checksum = "a7349e2f19a4dd304cb0ca90ce128125101fe9252ef0ffe879efe73bb8d5e7b4"
+let version = "128.0.20240525050247"
+let url = "https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/project.application-services.v2.swift.128.20240525050247/artifacts/public/build/MozillaRustComponents.xcframework.zip"
 
 // Focus xcframework
-let focusChecksum = "9011327af38444da2103b464639b48ba5841aab99c8245211a967325c87eb35f"
-let focusUrl = "https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/project.application-services.v2.swift.128.20240523050311/artifacts/public/build/FocusRustComponents.xcframework.zip"
+let focusChecksum = "372f3b1267e1078236c1f5de03faac31433de070dfc427400448ce86d4a8e28d"
+let focusUrl = "https://firefox-ci-tc.services.mozilla.com/api/index/v1/task/project.application-services.v2.swift.128.20240525050247/artifacts/public/build/FocusRustComponents.xcframework.zip"
 let package = Package(
     name: "MozillaRustComponentsSwift",
     platforms: [.iOS(.v14)],
diff --git a/swift-source/all/FxAClient/FxAccountManager.swift b/swift-source/all/FxAClient/FxAccountManager.swift
@@ -38,7 +38,7 @@ open class FxAccountManager {
     var constellation: DeviceConstellation?
     var latestOAuthStateParam: String?
 
-    /// Instanciate the account manager.
+    /// Instantiate the account manager.
     /// This class is intended to be long-lived within your app.
     /// `keychainAccessGroup` is especially important if you are
     /// using the manager in iOS App Extensions.
@@ -378,7 +378,7 @@ open class FxAccountManager {
                         profile = nil
                         constellation = nil
                         accountStorage.clear()
-                        // If we cannot instanciate FxA something is *really* wrong, crashing is a valid option.
+                        // If we cannot instantiate FxA something is *really* wrong, crashing is a valid option.
                         account = createAccount()
                         DispatchQueue.main.async {
                             NotificationCenter.default.post(
diff --git a/swift-source/all/FxAClient/MZKeychain/KeychainWrapper.swift b/swift-source/all/FxAClient/MZKeychain/KeychainWrapper.swift
@@ -332,7 +332,7 @@ open class MZKeychainWrapper {
         return removeObject(forKey: key, withAccessibility: accessibility, isSynchronizable: isSynchronizable)
     }
 
-    /// Remove an object associated with a specified key. If re-using a key but with a different accessibility, first remove the previous key value using removeObjectForKey(:withAccessibility) using the same accessibilty it was saved with.
+    /// Remove an object associated with a specified key. If re-using a key but with a different accessibility, first remove the previous key value using removeObjectForKey(:withAccessibility) using the same accessibility it was saved with.
     ///
     /// - parameter forKey: The key value to remove data for.
     /// - parameter withAccessibility: Optional accessibility level to use when looking up the keychain item.
@@ -346,7 +346,7 @@ open class MZKeychainWrapper {
         return status == errSecSuccess
     }
 
-    /// Remove all keychain data added through KeychainWrapper. This will only delete items matching the currnt ServiceName and AccessGroup if one is set.
+    /// Remove all keychain data added through KeychainWrapper. This will only delete items matching the current ServiceName and AccessGroup if one is set.
     @discardableResult open func removeAllKeys() -> Bool {
         // Setup dictionary to access keychain and specify we are using a generic password (rather than a certificate, internet password, etc)
         var keychainQueryDictionary: [String: Any] = [SecClass: kSecClassGenericPassword]
diff --git a/swift-source/all/FxAClient/PersistedFirefoxAccount.swift b/swift-source/all/FxAClient/PersistedFirefoxAccount.swift
@@ -32,14 +32,14 @@ class PersistedFirefoxAccount {
         self.init(inner: FirefoxAccount(config: config))
     }
 
-    /// Registers a persistance callback. The callback will get called every time
+    /// Registers a persistence callback. The callback will get called every time
     /// the `FxAccounts` state needs to be saved. The callback must
     /// persist the passed string in a secure location (like the keychain).
     public func registerPersistCallback(_ cb: PersistCallback) {
         persistCallback = cb
     }
 
-    /// Unregisters a persistance callback.
+    /// Unregisters a persistence callback.
     public func unregisterPersistCallback() {
         persistCallback = nil
     }
diff --git a/swift-source/all/Generated/Metrics/Metrics.swift b/swift-source/all/Generated/Metrics/Metrics.swift
@@ -23,7 +23,7 @@ extension GleanMetrics {
             // Intentionally left private, no external user can instantiate a new global object.
         }
 
-        public static let info = BuildInfo(buildDate: DateComponents(calendar: Calendar.current, timeZone: TimeZone(abbreviation: "UTC"), year: 2024, month: 5, day: 23, hour: 5, minute: 21, second: 42))
+        public static let info = BuildInfo(buildDate: DateComponents(calendar: Calendar.current, timeZone: TimeZone(abbreviation: "UTC"), year: 2024, month: 5, day: 25, hour: 5, minute: 20, second: 47))
     }
 
     enum NimbusEvents {
diff --git a/swift-source/all/Logins/LoginsStorage.swift b/swift-source/all/Logins/LoginsStorage.swift
@@ -10,7 +10,7 @@ typealias LoginsStoreError = LoginsApiError
 
 /*
  ** We probably should have this class go away eventually as it's really only a thin wrapper
- * similar to its kotlin equiavlent, however the only thing preventing this from being removed is
+ * similar to its kotlin equivalents, however the only thing preventing this from being removed is
  * the queue.sync which we should be moved over to the consumer side of things
  */
 open class LoginsStorage {
diff --git a/swift-source/all/Nimbus/Collections+.swift b/swift-source/all/Nimbus/Collections+.swift
@@ -31,7 +31,7 @@ public extension Dictionary {
 
     func mergeWith(_ defaults: [Key: Value], _ valueMerger: ((Value, Value) -> Value)? = nil) -> [Key: Value] {
         guard let valueMerger = valueMerger else {
-            return merging(defaults, uniquingKeysWith: { overide, _ in overide })
+            return merging(defaults, uniquingKeysWith: { override, _ in override })
         }
 
         return merging(defaults, uniquingKeysWith: valueMerger)
diff --git a/swift-source/all/Nimbus/FeatureVariables.swift b/swift-source/all/Nimbus/FeatureVariables.swift
@@ -44,7 +44,7 @@ public protocol Variables {
     /// Returns the whole variables object as a string map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to strings
-    ///  - Returns: a `[String:String]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:String]` dictionary representing the whole variables object
     func asStringMap() -> [String: String]?
 
     /// Finds a integer typed value for this key. If none exists, `nil` is returned.
@@ -63,7 +63,7 @@ public protocol Variables {
     /// Returns the whole variables object as an Int map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to Ints
-    ///  - Returns: a `[String:Int]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:Int]` dictionary representing the whole variables object
     func asIntMap() -> [String: Int]?
 
     /// Finds a boolean typed value for this key. If none exists, `nil` is returned.
@@ -82,7 +82,7 @@ public protocol Variables {
     /// Returns the whole variables object as a boolean map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to booleans
-    ///  - Returns: a `[String:Bool]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:Bool]` dictionary representing the whole variables object
     func asBoolMap() -> [String: Bool]?
 
     /// Uses `getString(key: String)` to find the name of a drawable resource. If no value for `key`
@@ -135,7 +135,7 @@ public protocol Variables {
     /// Returns the whole variables object as a variables map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to a class representing variables
-    ///  - Returns: a `[String:Variables]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:Variables]` dictionary representing the whole variables object
     func asVariablesMap() -> [String: Variables]?
 }
 
diff --git a/swift-source/all/Nimbus/Nimbus.swift b/swift-source/all/Nimbus/Nimbus.swift
@@ -120,7 +120,7 @@ extension Nimbus: FeaturesInterface {
 
     func postEnrollmentCalculation(_ events: [EnrollmentChangeEvent]) {
         // We need to update the experiment enrollment annotations in Glean
-        // regardless of whether we recieved any events. Calling the
+        // regardless of whether we received any events. Calling the
         // `setExperimentActive` function multiple times with the same
         // experiment id is safe so nothing bad should happen in case we do.
         let experiments = getActiveExperiments()
diff --git a/swift-source/all/Nimbus/NimbusApi.swift b/swift-source/all/Nimbus/NimbusApi.swift
@@ -247,7 +247,7 @@ public let remoteSettingsCollection = "nimbus-mobile-experiments"
 public let remoteSettingsPreviewCollection = "nimbus-preview"
 
 /// Name, channel and specific context of the app which should agree with what is specified in Experimenter.
-/// The specifc context is there to capture any context that the SDK doesn't need to be explictly aware of.
+/// The specific context is there to capture any context that the SDK doesn't need to be explicitly aware of.
 ///
 public struct NimbusAppSettings {
     public init(appName: String, channel: String, customTargetingAttributes: [String: Any] = [String: Any]()) {
diff --git a/swift-source/all/Nimbus/Utils/Sysctl.swift b/swift-source/all/Nimbus/Utils/Sysctl.swift
@@ -94,7 +94,7 @@ struct Sysctl {
         return keysBuffer
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as the specified type.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as the specified type.
     /// This function will throw `Error.invalidSize` if the size of buffer returned from `sysctl` fails to match the size of `T`.
     public static func value<T>(ofType _: T.Type, forKeys keys: [Int32]) throws -> T {
         let buffer = try data(for: keys)
@@ -107,7 +107,7 @@ struct Sysctl {
         }
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as the specified type.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as the specified type.
     /// This function will throw `Error.invalidSize` if the size of buffer returned from `sysctl` fails to match the size of `T`.
     public static func value<T>(ofType type: T.Type, forKeys keys: Int32...) throws -> T {
         return try value(ofType: type, forKeys: keys)
@@ -119,7 +119,7 @@ struct Sysctl {
         return try value(ofType: type, forKeys: keys(for: name))
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as a `String`.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as a `String`.
     /// This function will throw `Error.malformedUTF8` if the buffer returned from `sysctl` cannot be interpreted as a UTF8 buffer.
     public static func string(for keys: [Int32]) throws -> String {
         let optionalString = try data(for: keys).withUnsafeBufferPointer { dataPointer -> String? in
@@ -131,7 +131,7 @@ struct Sysctl {
         return s
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as a `String`.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as a `String`.
     /// This function will throw `Error.malformedUTF8` if the buffer returned from `sysctl` cannot be interpreted as a UTF8 buffer.
     public static func string(for keys: Int32...) throws -> String {
         return try string(for: keys)
diff --git a/swift-source/all/Places/Places.swift b/swift-source/all/Places/Places.swift
@@ -438,7 +438,7 @@ public class PlacesWriteConnection: PlacesReadConnection {
      * - Deleting older visits when the database exceeds dbSizeLimit
      * - etc.
      *
-     * Maintanance in performed in small chunks at a time to avoid blocking the
+     * Maintenance in performed in small chunks at a time to avoid blocking the
      * DB connection for too long.  This means that this should be called
      * regularly when the app is idle.
      *
diff --git a/swift-source/focus/Generated/Metrics/Metrics.swift b/swift-source/focus/Generated/Metrics/Metrics.swift
@@ -23,7 +23,7 @@ extension GleanMetrics {
             // Intentionally left private, no external user can instantiate a new global object.
         }
 
-        public static let info = BuildInfo(buildDate: DateComponents(calendar: Calendar.current, timeZone: TimeZone(abbreviation: "UTC"), year: 2024, month: 5, day: 23, hour: 5, minute: 21, second: 44))
+        public static let info = BuildInfo(buildDate: DateComponents(calendar: Calendar.current, timeZone: TimeZone(abbreviation: "UTC"), year: 2024, month: 5, day: 25, hour: 5, minute: 20, second: 49))
     }
 
     enum NimbusEvents {
diff --git a/swift-source/focus/Nimbus/Collections+.swift b/swift-source/focus/Nimbus/Collections+.swift
@@ -31,7 +31,7 @@ public extension Dictionary {
 
     func mergeWith(_ defaults: [Key: Value], _ valueMerger: ((Value, Value) -> Value)? = nil) -> [Key: Value] {
         guard let valueMerger = valueMerger else {
-            return merging(defaults, uniquingKeysWith: { overide, _ in overide })
+            return merging(defaults, uniquingKeysWith: { override, _ in override })
         }
 
         return merging(defaults, uniquingKeysWith: valueMerger)
diff --git a/swift-source/focus/Nimbus/FeatureVariables.swift b/swift-source/focus/Nimbus/FeatureVariables.swift
@@ -44,7 +44,7 @@ public protocol Variables {
     /// Returns the whole variables object as a string map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to strings
-    ///  - Returns: a `[String:String]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:String]` dictionary representing the whole variables object
     func asStringMap() -> [String: String]?
 
     /// Finds a integer typed value for this key. If none exists, `nil` is returned.
@@ -63,7 +63,7 @@ public protocol Variables {
     /// Returns the whole variables object as an Int map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to Ints
-    ///  - Returns: a `[String:Int]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:Int]` dictionary representing the whole variables object
     func asIntMap() -> [String: Int]?
 
     /// Finds a boolean typed value for this key. If none exists, `nil` is returned.
@@ -82,7 +82,7 @@ public protocol Variables {
     /// Returns the whole variables object as a boolean map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to booleans
-    ///  - Returns: a `[String:Bool]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:Bool]` dictionary representing the whole variables object
     func asBoolMap() -> [String: Bool]?
 
     /// Uses `getString(key: String)` to find the name of a drawable resource. If no value for `key`
@@ -135,7 +135,7 @@ public protocol Variables {
     /// Returns the whole variables object as a variables map
     /// will return `nil` if it cannot be converted
     ///  - Note: This function will omit any variables that could not be converted to a class representing variables
-    ///  - Returns: a `[String:Variables]` dictonary representing the whole variables object
+    ///  - Returns: a `[String:Variables]` dictionary representing the whole variables object
     func asVariablesMap() -> [String: Variables]?
 }
 
diff --git a/swift-source/focus/Nimbus/Nimbus.swift b/swift-source/focus/Nimbus/Nimbus.swift
@@ -120,7 +120,7 @@ extension Nimbus: FeaturesInterface {
 
     func postEnrollmentCalculation(_ events: [EnrollmentChangeEvent]) {
         // We need to update the experiment enrollment annotations in Glean
-        // regardless of whether we recieved any events. Calling the
+        // regardless of whether we received any events. Calling the
         // `setExperimentActive` function multiple times with the same
         // experiment id is safe so nothing bad should happen in case we do.
         let experiments = getActiveExperiments()
diff --git a/swift-source/focus/Nimbus/NimbusApi.swift b/swift-source/focus/Nimbus/NimbusApi.swift
@@ -247,7 +247,7 @@ public let remoteSettingsCollection = "nimbus-mobile-experiments"
 public let remoteSettingsPreviewCollection = "nimbus-preview"
 
 /// Name, channel and specific context of the app which should agree with what is specified in Experimenter.
-/// The specifc context is there to capture any context that the SDK doesn't need to be explictly aware of.
+/// The specific context is there to capture any context that the SDK doesn't need to be explicitly aware of.
 ///
 public struct NimbusAppSettings {
     public init(appName: String, channel: String, customTargetingAttributes: [String: Any] = [String: Any]()) {
diff --git a/swift-source/focus/Nimbus/Utils/Sysctl.swift b/swift-source/focus/Nimbus/Utils/Sysctl.swift
@@ -94,7 +94,7 @@ struct Sysctl {
         return keysBuffer
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as the specified type.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as the specified type.
     /// This function will throw `Error.invalidSize` if the size of buffer returned from `sysctl` fails to match the size of `T`.
     public static func value<T>(ofType _: T.Type, forKeys keys: [Int32]) throws -> T {
         let buffer = try data(for: keys)
@@ -107,7 +107,7 @@ struct Sysctl {
         }
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as the specified type.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as the specified type.
     /// This function will throw `Error.invalidSize` if the size of buffer returned from `sysctl` fails to match the size of `T`.
     public static func value<T>(ofType type: T.Type, forKeys keys: Int32...) throws -> T {
         return try value(ofType: type, forKeys: keys)
@@ -119,7 +119,7 @@ struct Sysctl {
         return try value(ofType: type, forKeys: keys(for: name))
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as a `String`.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as a `String`.
     /// This function will throw `Error.malformedUTF8` if the buffer returned from `sysctl` cannot be interpreted as a UTF8 buffer.
     public static func string(for keys: [Int32]) throws -> String {
         let optionalString = try data(for: keys).withUnsafeBufferPointer { dataPointer -> String? in
@@ -131,7 +131,7 @@ struct Sysctl {
         return s
     }
 
-    /// Invoke `sysctl` with an array of identifers, interpreting the returned buffer as a `String`.
+    /// Invoke `sysctl` with an array of identifiers, interpreting the returned buffer as a `String`.
     /// This function will throw `Error.malformedUTF8` if the buffer returned from `sysctl` cannot be interpreted as a UTF8 buffer.
     public static func string(for keys: Int32...) throws -> String {
         return try string(for: keys)

Original file line number	Diff line number	Diff line change
`@@ -32,14 +32,14 @@ class PersistedFirefoxAccount {`
`32`	`32`	`self.init(inner: FirefoxAccount(config: config))`
`33`	`33`	`}`
`34`	`34`
`35`		`- /// Registers a persistance callback. The callback will get called every time`
	`35`	`+ /// Registers a persistence callback. The callback will get called every time`
`36`	`36`	/// the `FxAccounts` state needs to be saved. The callback must
`37`	`37`	`/// persist the passed string in a secure location (like the keychain).`
`38`	`38`	`public func registerPersistCallback(_ cb: PersistCallback) {`
`39`	`39`	`persistCallback = cb`
`40`	`40`	`}`
`41`	`41`
`42`		`- /// Unregisters a persistance callback.`
	`42`	`+ /// Unregisters a persistence callback.`
`43`	`43`	`public func unregisterPersistCallback() {`
`44`	`44`	`persistCallback = nil`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ extension GleanMetrics {`
`23`	`23`	`// Intentionally left private, no external user can instantiate a new global object.`
`24`	`24`	`}`
`25`	`25`
`26`		`- public static let info = BuildInfo(buildDate: DateComponents(calendar: Calendar.current, timeZone: TimeZone(abbreviation: "UTC"), year: 2024, month: 5, day: 23, hour: 5, minute: 21, second: 42))`
	`26`	`+ public static let info = BuildInfo(buildDate: DateComponents(calendar: Calendar.current, timeZone: TimeZone(abbreviation: "UTC"), year: 2024, month: 5, day: 25, hour: 5, minute: 20, second: 47))`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`enum NimbusEvents {`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public extension Dictionary {`
`31`	`31`
`32`	`32`	`func mergeWith(_ defaults: [Key: Value], _ valueMerger: ((Value, Value) -> Value)? = nil) -> [Key: Value] {`
`33`	`33`	`guard let valueMerger = valueMerger else {`
`34`		`- return merging(defaults, uniquingKeysWith: { overide, _ in overide })`
	`34`	`+ return merging(defaults, uniquingKeysWith: { override, _ in override })`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`return merging(defaults, uniquingKeysWith: valueMerger)`