Fix clippy lints

All pretty straight forward.
mod.rs in tests/harness should probably be refactored at some point to
actually check all the possible errors and not just
drop results, as is common there.

Signed-off-by: Jonathan Schwender <[email protected]>

Author: jschwe

src/compiler/args.rs

@@ -307,6 +307,7 @@ macro_rules! ArgData {
     };
     { $( $tok:tt )+ } => {
         #[derive(Clone, Debug, PartialEq)]
+        #[allow(clippy::enum_variant_names)]
         enum ArgData {
             $($tok)+
         }

src/compiler/msvc.rs

@@ -581,7 +581,7 @@ pub fn parse_arguments(
             let arg = try_or_cannot_cache!(arg, "argument parse");
             // Eagerly bail if it looks like we need to do more complicated work
             use crate::compiler::gcc::ArgData::*;
-            let mut args = match arg.get_data() {
+            let args = match arg.get_data() {
                 Some(SplitDwarf) | Some(TestCoverage) | Some(Coverage) | Some(DoCompilation)
                 | Some(Language(_)) | Some(Output(_)) | Some(TooHardFlag) | Some(XClang(_))
                 | Some(TooHard(_)) => cannot_cache!(arg
@@ -621,7 +621,7 @@ pub fn parse_arguments(
                 _ => NormalizedDisposition::Separated,
             };
             for arg in arg.normalize(norm).iter_os_strings() {
-                append_fn(arg, &mut args);
+                append_fn(arg, args);
             }
         }
     }

src/config.rs

@@ -247,7 +247,7 @@ impl CacheConfigs {
             .chain(gcs.map(CacheType::GCS))
             .chain(azure.map(CacheType::Azure))
             .collect();
-        let fallback = disk.unwrap_or_else(Default::default);
+        let fallback = disk.unwrap_or_default();
 
         (caches, fallback)
     }

src/simples3/s3.rs

@@ -195,13 +195,14 @@ impl Bucket {
         creds: &AwsCredentials,
     ) -> String {
         let string = format!(
-            "{verb}\n{md5}\n{ty}\n{date}\n{headers}{resource}",
+            "{verb}\n{md5}\n{ty}\n{date}\n{headers}/{name}/{path}",
             verb = verb,
             md5 = md5,
             ty = content_type,
             date = date,
             headers = headers,
-            resource = format!("/{}/{}", self.name, path)
+            name = self.name,
+            path = path,
         );
         let signature = signature(&string, creds.aws_secret_access_key());
         format!("AWS {}:{}", creds.aws_access_key_id(), signature)

tests/harness/mod.rs

@@ -53,7 +53,7 @@ const TC_CACHE_SIZE: u64 = 1024 * 1024 * 1024; // 1 gig
 pub fn start_local_daemon(cfg_path: &Path, cached_cfg_path: &Path) {
     // Don't run this with run() because on Windows `wait_with_output`
     // will hang because the internal server process is not detached.
-    sccache_command()
+    let _ = sccache_command()
         .arg("--start-server")
         .env("SCCACHE_CONF", cfg_path)
         .env("SCCACHE_CACHED_CONF", cached_cfg_path)