Skip to content

Commit ff98826

Browse files
ogiorgisArchaeopteryx
authored andcommitted
fix: stop posting build types in the variant column
1 parent 9cf139e commit ff98826

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

tests/intermittents_commenter/expected_comment.text

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ This is the #1 most frequent failure this week.
55
* mozilla-central: 1
66

77
## Table
8-
| |**debug**|**no_variant**|**opt**|**spi-nw**|
9-
|---|:-:|:-:|:-:|:-:|
10-
|**macosx1015-x86_64/debug**| | | |1/22|
8+
| |**no_variant**|**socketprocess_networking**|**spi-nw**|
9+
|---|:-:|:-:|:-:|
10+
|**macosx1015-x86_64/debug**| | |1/22|
1111

1212
## For more details, see:
1313
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1&startday=2022-05-09&endday=2025-05-10&tree=all

tests/intermittents_commenter/expected_comment_with_5_failures.text

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ This is the #1 most frequent failure this week.
55
* mozilla-central: 5
66

77
## Table
8-
| |**1proc**|**asan**|**debug**|**no_variant**|**opt**|**spi-nw**|**swr**|**tsan**|
9-
|---|:-:|:-:|:-:|:-:|:-:|:-:|:-:|:-:|
10-
|**linux1804-x86_64/debug**|1| | |1| |1/92| | |
11-
|**macosx1015-x86_64/debug**| | | | | |1/22| | |
12-
|**macosx1470-x86_64/debug**| | | | | | |1| |
8+
| |**1proc**|**a11y_checks+swgl**|**no_variant**|**socketprocess_networking**|**spi-nw**|**swgl**|**swr**|
9+
|---|:-:|:-:|:-:|:-:|:-:|:-:|:-:|
10+
|**linux1804-x86_64/debug**|1| |1| |1/92| | |
11+
|**macosx1015-x86_64/debug**| | | | |1/22| | |
12+
|**macosx1470-x86_64/debug**| | | | | | |1|
1313

1414
## For more details, see:
1515
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1&startday=2022-05-09&endday=2025-05-10&tree=all

treeherder/intermittents_commenter/commenter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,13 +344,13 @@ def get_all_test_variants(self, bug_run_info, testrun_os_matrix):
344344
"""
345345
Try to provide a mapping between the artifact giving the manifest
346346
and the data available in treeherder.
347-
TODO: not very consistant
348347
"""
349348
variants = set()
350349
for key_version in testrun_os_matrix:
351350
if key_version.replace(".", "") in bug_run_info.os_version:
352351
for key_arch in testrun_os_matrix[key_version]:
353-
variants = set(testrun_os_matrix[key_version][key_arch].keys())
352+
for key_type in testrun_os_matrix[key_version][key_arch]:
353+
variants |= set(testrun_os_matrix[key_version][key_arch][key_type].keys())
354354
variants.add("no_variant") # this is an assumption, we might not always have this
355355
return variants
356356

0 commit comments

Comments
 (0)