Skip to content

Commit 566b4d0

Browse files
committed
Refactor exceptions section layout in app.ts
Organize global and per-site exceptions into separate sections with descriptive paragraphs for clarity. Update z-index values for better visual hierarchy.
1 parent c158875 commit 566b4d0

File tree

1 file changed

+62
-49
lines changed

1 file changed

+62
-49
lines changed

src/app.ts

Lines changed: 62 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -244,55 +244,68 @@ export class App extends LitElement {
244244
exceptions resolve a lot of untracked site breakage, i.e. breakage we don't have a bug for.
245245
</p>
246246
247-
<h2 style="z-index: 10;">Global Exceptions</h2>
248-
249-
<h3 style="z-index: 20;">Baseline</h3>
250-
<exceptions-table
251-
id="global-baseline"
252-
.entries=${this.records}
253-
.bugMeta=${this.bugMeta}
254-
.filter=${(entry: ExceptionListEntry) =>
255-
!entry.topLevelUrlPattern?.length && entry.category === "baseline"}
256-
></exceptions-table>
257-
258-
<h3 style="z-index: 30;">Convenience</h3>
259-
<exceptions-table
260-
id="global-convenience"
261-
.entries=${this.records}
262-
.bugMeta=${this.bugMeta}
263-
.filter=${(entry: ExceptionListEntry) =>
264-
!entry.topLevelUrlPattern?.length && entry.category === "convenience"}
265-
></exceptions-table>
266-
267-
<h2 style="z-index: 40;">Per-Site Exceptions</h2>
268-
<h3 style="z-index: 50;">Baseline</h3>
269-
<exceptions-table
270-
id="per-site-baseline"
271-
.entries=${this.records}
272-
.bugMeta=${this.bugMeta}
273-
.filter=${(entry: ExceptionListEntry) =>
274-
!!entry.topLevelUrlPattern?.length && entry.category === "baseline"}
275-
></exceptions-table>
276-
277-
<h3 style="z-index: 60;">Convenience</h3>
278-
<exceptions-table
279-
id="per-site-convenience"
280-
.entries=${this.records}
281-
.bugMeta=${this.bugMeta}
282-
.filter=${(entry: ExceptionListEntry) =>
283-
!!entry.topLevelUrlPattern?.length && entry.category === "convenience"}
284-
></exceptions-table>
285-
286-
<h3 style="z-index: 70;">Top Resources</h3>
287-
<p>
288-
This table shows the top resources that are allow-listed via site-specific exception list
289-
entries. If a resource is allow-listed under many top level sites, it can be an indicator
290-
that it should be added to the global exceptions list.
291-
</p>
292-
<top-exceptions-table
293-
.entries=${this.records}
294-
.bugMeta=${this.bugMeta}
295-
></top-exceptions-table>
247+
<section style="z-index: 10;">
248+
<h2 style="z-index: 20;">Global Exceptions</h2>
249+
<p>
250+
Global exceptions are applied for sub-resources across all top level sites. They are
251+
applied when blocking a resource breaks many sites.
252+
</p>
253+
254+
<h3 style="z-index: 30;">Baseline</h3>
255+
<exceptions-table
256+
id="global-baseline"
257+
.entries=${this.records}
258+
.bugMeta=${this.bugMeta}
259+
.filter=${(entry: ExceptionListEntry) =>
260+
!entry.topLevelUrlPattern?.length && entry.category === "baseline"}
261+
></exceptions-table>
262+
263+
<h3 style="z-index: 40;">Convenience</h3>
264+
<exceptions-table
265+
id="global-convenience"
266+
.entries=${this.records}
267+
.bugMeta=${this.bugMeta}
268+
.filter=${(entry: ExceptionListEntry) =>
269+
!entry.topLevelUrlPattern?.length && entry.category === "convenience"}
270+
></exceptions-table>
271+
</section>
272+
273+
<section style="z-index: 50;">
274+
<h2 style="z-index: 60;">Per-Site Exceptions</h2>
275+
<p>
276+
Per-site exceptions are applied for sub-resources on a specific top level site. They are
277+
applied for site specific breakage.
278+
</p>
279+
280+
<h3 style="z-index: 70;">Baseline</h3>
281+
<exceptions-table
282+
id="per-site-baseline"
283+
.entries=${this.records}
284+
.bugMeta=${this.bugMeta}
285+
.filter=${(entry: ExceptionListEntry) =>
286+
!!entry.topLevelUrlPattern?.length && entry.category === "baseline"}
287+
></exceptions-table>
288+
289+
<h3 style="z-index: 80;">Convenience</h3>
290+
<exceptions-table
291+
id="per-site-convenience"
292+
.entries=${this.records}
293+
.bugMeta=${this.bugMeta}
294+
.filter=${(entry: ExceptionListEntry) =>
295+
!!entry.topLevelUrlPattern?.length && entry.category === "convenience"}
296+
></exceptions-table>
297+
298+
<h3 style="z-index: 90;">Top Resources</h3>
299+
<p>
300+
This table shows the top resources that are allow-listed via site-specific exception list
301+
entries. If a resource is allow-listed under many top level sites, it can be an indicator
302+
that it should be added to the global exceptions list.
303+
</p>
304+
<top-exceptions-table
305+
.entries=${this.records}
306+
.bugMeta=${this.bugMeta}
307+
></top-exceptions-table>
308+
</section>
296309
`;
297310
}
298311

0 commit comments

Comments
 (0)