chore(printf): small improvments

mpaland · mpaland · commit 50c954121c6c · 2018-09-24T17:33:05.000+02:00
diff --git a/printf.c b/printf.c
@@ -138,7 +138,7 @@ static inline bool _is_digit(char ch)
 
 
 // internal ASCII string to unsigned int conversion
-static inline unsigned int _atoi(const char** str)
+static unsigned int _atoi(const char** str)
 {
   unsigned int i = 0U;
   while (_is_digit(**str)) {
@@ -172,10 +172,10 @@ static size_t _ntoa_format(out_fct_type out, char* buffer, size_t idx, size_t ma
     if ((base == 16U) && !(flags & FLAGS_UPPERCASE) && (len < PRINTF_NTOA_BUFFER_SIZE)) {
       buf[len++] = 'x';
     }
-    if ((base == 16U) &&  (flags & FLAGS_UPPERCASE) && (len < PRINTF_NTOA_BUFFER_SIZE)) {
+    else if ((base == 16U) && (flags & FLAGS_UPPERCASE) && (len < PRINTF_NTOA_BUFFER_SIZE)) {
       buf[len++] = 'X';
     }
-    if ((base == 2U) && (len < PRINTF_NTOA_BUFFER_SIZE)) {
+    else if ((base == 2U) && (len < PRINTF_NTOA_BUFFER_SIZE)) {
       buf[len++] = 'b';
     }
     if (len < PRINTF_NTOA_BUFFER_SIZE) {

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ static inline bool _is_digit(char ch)`
`138`	`138`
`139`	`139`
`140`	`140`	`// internal ASCII string to unsigned int conversion`
`141`		`-static inline unsigned int _atoi(const char** str)`
	`141`	`+static unsigned int _atoi(const char** str)`
`142`	`142`	`{`
`143`	`143`	`unsigned int i = 0U;`
`144`	`144`	`while (_is_digit(**str)) {`
`@@ -172,10 +172,10 @@ static size_t _ntoa_format(out_fct_type out, char* buffer, size_t idx, size_t ma`
`172`	`172`	`if ((base == 16U) && !(flags & FLAGS_UPPERCASE) && (len < PRINTF_NTOA_BUFFER_SIZE)) {`
`173`	`173`	`buf[len++] = 'x';`
`174`	`174`	`}`
`175`		`- if ((base == 16U) && (flags & FLAGS_UPPERCASE) && (len < PRINTF_NTOA_BUFFER_SIZE)) {`
	`175`	`+ else if ((base == 16U) && (flags & FLAGS_UPPERCASE) && (len < PRINTF_NTOA_BUFFER_SIZE)) {`
`176`	`176`	`buf[len++] = 'X';`
`177`	`177`	`}`
`178`		`- if ((base == 2U) && (len < PRINTF_NTOA_BUFFER_SIZE)) {`
	`178`	`+ else if ((base == 2U) && (len < PRINTF_NTOA_BUFFER_SIZE)) {`
`179`	`179`	`buf[len++] = 'b';`
`180`	`180`	`}`
`181`	`181`	`if (len < PRINTF_NTOA_BUFFER_SIZE) {`