feat: Map selected identity to #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mansi-mParticle
force-pushed
the
SQDSDKS-7633-Map-identity-to-emailsha256
branch
from
c31464a to
357b352
Compare
Mansi-mParticle
force-pushed
the
SQDSDKS-7633-Map-identity-to-emailsha256
branch
from
357b352 to
9b82749
Compare
rmi22186
reviewed
Aug 28, 2025
| ) | ||
| val hashedField = RoktKit::class.java.getDeclaredField("hashedEmailUserIdentityType") | ||
| hashedField.isAccessible = true | ||
| hashedField.set(roktKit, "UNASSIGNED") |
There was a problem hiding this comment.
https://github.com/mparticle-by-rokt/mPServer/pull/35784/files
I copied from Brian's PR in order to keep it consistent
rmi22186
reviewed
Aug 28, 2025
Comment on lines
+386
to
+407
| IdentityType.Other -> "Other" | ||
| IdentityType.CustomerId -> "CustomerId" | ||
| IdentityType.Facebook -> "Facebook" | ||
| IdentityType.Twitter -> "Twitter" | ||
| IdentityType.Google -> "Google" | ||
| IdentityType.Microsoft -> "Microsoft" | ||
| IdentityType.Yahoo -> "Yahoo" | ||
| IdentityType.Email -> "Email" | ||
| IdentityType.Alias -> "Alias" | ||
| IdentityType.FacebookCustomAudienceId -> "FacebookCustomAudienceId" | ||
| IdentityType.Other2 -> "Other2" | ||
| IdentityType.Other3 -> "Other3" | ||
| IdentityType.Other4 -> "Other4" | ||
| IdentityType.Other5 -> "Other5" | ||
| IdentityType.Other6 -> "Other6" | ||
| IdentityType.Other7 -> "Other7" | ||
| IdentityType.Other8 -> "Other8" | ||
| IdentityType.Other9 -> "Other9" | ||
| IdentityType.Other10 -> "Other10" | ||
| IdentityType.MobileNumber -> "MobileNumber" | ||
| IdentityType.PhoneNumber2 -> "PhoneNumber2" | ||
| IdentityType.PhoneNumber3 -> "PhoneNumber3" |
There was a problem hiding this comment.
Is there a reason you reverted to capitalizing?
the attributes on rokt's site are all lowercase (and I'm not sure if casing matters)
https://docs.rokt.com/developers/integration-guides/rokt-ads/web-sdk/attributes/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)