feat: Add product brand to commerce event products (#28)

v-mamaya · einsteinx2 · commit 245e42fdf1c6 · 2024-06-12T09:03:15.000-05:00
diff --git a/mParticle-Google-Analytics-Firebase-GA4/MPKitFirebaseGA4Analytics.m b/mParticle-Google-Analytics-Firebase-GA4/MPKitFirebaseGA4Analytics.m
@@ -529,6 +529,9 @@ - (NSString *)getEventNameForCommerceEvent:(MPCommerceEvent *)commerceEvent para
             if (product.category) {
                 [productParameters setObject:product.category forKey:kFIRParameterItemCategory];
             }
+            if (product.brand) {
+                [productParameters setObject:product.brand forKey:kFIRParameterItemBrand];
+            }
             if (product.price) {
                 [productParameters setObject:product.price forKey:kFIRParameterPrice];
             }
@@ -565,6 +568,9 @@ - (NSString *)getEventNameForCommerceEvent:(MPCommerceEvent *)commerceEvent para
         if (product.category) {
             [productParameters setObject:product.category forKey:kFIRParameterItemCategory];
         }
+        if (product.brand) {
+            [productParameters setObject:product.brand forKey:kFIRParameterItemBrand];
+        }
         if (product.price) {
             [productParameters setObject:product.price forKey:kFIRParameterPrice];
         }

Original file line number	Diff line number	Diff line change
`@@ -529,6 +529,9 @@ - (NSString )getEventNameForCommerceEvent:(MPCommerceEvent )commerceEvent para`
`529`	`529`	`if (product.category) {`
`530`	`530`	`[productParameters setObject:product.category forKey:kFIRParameterItemCategory];`
`531`	`531`	`}`
	`532`	`+ if (product.brand) {`
	`533`	`+ [productParameters setObject:product.brand forKey:kFIRParameterItemBrand];`
	`534`	`+ }`
`532`	`535`	`if (product.price) {`
`533`	`536`	`[productParameters setObject:product.price forKey:kFIRParameterPrice];`
`534`	`537`	`}`
`@@ -565,6 +568,9 @@ - (NSString )getEventNameForCommerceEvent:(MPCommerceEvent )commerceEvent para`
`565`	`568`	`if (product.category) {`
`566`	`569`	`[productParameters setObject:product.category forKey:kFIRParameterItemCategory];`
`567`	`570`	`}`
	`571`	`+ if (product.brand) {`
	`572`	`+ [productParameters setObject:product.brand forKey:kFIRParameterItemBrand];`
	`573`	`+ }`
`568`	`574`	`if (product.price) {`
`569`	`575`	`[productParameters setObject:product.price forKey:kFIRParameterPrice];`
`570`	`576`	`}`