Skip to content

Commit 7b1a121

Browse files
einsteinx2einsteinx2
authored
feat: Improve Privacy Manifest support for iOS 17 (#18)
1 parent daad803 commit 7b1a121

File tree

7 files changed

+51
-81
lines changed

7 files changed

+51
-81
lines changed

‎Cartfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
github "optimizely/swift-sdk" ~> 3.1
2-
github "mparticle/mparticle-apple-sdk" ~> 8.0
1+
github "optimizely/swift-sdk" ~> 4.0
2+
binary "https://raw.githubusercontent.com/mParticle/mparticle-apple-sdk/main/mParticle_Apple_SDK.json" ~> 8.22

‎Package.swift‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ let package = Package(
1212
dependencies: [
1313
.package(name: "mParticle-Apple-SDK",
1414
url: "https://github.com/mParticle/mparticle-apple-sdk",
15-
.upToNextMajor(from: "8.0.0")),
15+
.upToNextMajor(from: "8.22.0")),
1616
.package(name: "Optimizely",
1717
url: "https://github.com/optimizely/swift-sdk",
1818
.upToNextMajor(from: "4.0.0")),
@@ -22,6 +22,7 @@ let package = Package(
2222
name: "mParticle_Optimizely",
2323
dependencies: ["mParticle-Apple-SDK", "Optimizely"],
2424
path: "mParticle_Optimizely",
25+
resources: [.process("PrivacyInfo.xcprivacy")],
2526
publicHeadersPath: "."
2627
),
2728
]

‎mParticle-Optimizely.podspec‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@ Pod::Spec.new do |s|
1212
s.author = { "mParticle" => "[email protected]" }
1313
s.source = { :git => "https://github.com/mparticle-integrations/mparticle-apple-integration-optimizely.git", :tag => "v" +s.version.to_s }
1414
s.social_media_url = "https://twitter.com/mparticle"
15-
s.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.0'
15+
s.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.22'
1616
s.dependency 'OptimizelySwiftSDK', '~> 4.0'
1717
s.swift_versions = ['5.0']
1818

1919
s.ios.deployment_target = "10.0"
2020
s.ios.source_files = 'mParticle_Optimizely/*.{h,m,mm}'
21-
s.ios.frameworks = 'CoreTelephony', 'SystemConfiguration'
22-
s.libraries = 'z'
21+
s.ios.resource_bundles = { 'mParticle-Optimizely-Privacy' => ['mParticle_Optimizely/PrivacyInfo.xcprivacy'] }
2322

2423
s.tvos.deployment_target = "10.0"
2524
s.tvos.source_files = 'mParticle_Optimizely/*.{h,m,mm}'
26-
s.tvos.frameworks = 'SystemConfiguration'
25+
s.tvos.resource_bundles = { 'mParticle-Optimizely-Privacy' => ['mParticle_Optimizely/PrivacyInfo.xcprivacy'] }
2726
end

‎mParticle_Optimizely.xcodeproj/project.pbxproj‎

Lines changed: 38 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,17 @@
33
archiveVersion = 1;
44
classes = {
55
};
6-
objectVersion = 50;
6+
objectVersion = 60;
77
objects = {
88

99
/* Begin PBXBuildFile section */
10+
53DE7F822BEA868400907F6D /* mParticle_Apple_SDK.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53DE7F7F2BEA868400907F6D /* mParticle_Apple_SDK.xcframework */; };
11+
53DE7F832BEA868400907F6D /* Optimizely.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53DE7F802BEA868400907F6D /* Optimizely.xcframework */; };
12+
53DE7F872BEA879900907F6D /* OCMock.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53DE7F7E2BEA868400907F6D /* OCMock.xcframework */; };
13+
53DE7F882BEA879A00907F6D /* OCMock.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53DE7F7E2BEA868400907F6D /* OCMock.xcframework */; };
14+
53DE7F892BEA8ACD00907F6D /* mParticle_Apple_SDK.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53DE7F7F2BEA868400907F6D /* mParticle_Apple_SDK.xcframework */; };
15+
53DE7F8B2BEA8ACD00907F6D /* Optimizely.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 53DE7F802BEA868400907F6D /* Optimizely.xcframework */; };
16+
53DE7F8E2BEA8AE700907F6D /* mParticle_Optimizely_tvOS.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D308517E219B2CEC00D1C15A /* mParticle_Optimizely_tvOS.framework */; };
1017
D308518C219B2CED00D1C15A /* mParticle_Optimizely_tvOSTests.m in Sources */ = {isa = PBXBuildFile; fileRef = D308518B219B2CED00D1C15A /* mParticle_Optimizely_tvOSTests.m */; };
1118
D308518E219B2CED00D1C15A /* mParticle_Optimizely_tvOS.h in Headers */ = {isa = PBXBuildFile; fileRef = D3085180219B2CEC00D1C15A /* mParticle_Optimizely_tvOS.h */; settings = {ATTRIBUTES = (Public, ); }; };
1219
D3085195219B447600D1C15A /* MPKitOptimizely.h in Headers */ = {isa = PBXBuildFile; fileRef = D316BD4C217F67BC00688E56 /* MPKitOptimizely.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -16,18 +23,18 @@
1623
D316BD43217F670600688E56 /* mParticle_Optimizely.h in Headers */ = {isa = PBXBuildFile; fileRef = D316BD35217F670500688E56 /* mParticle_Optimizely.h */; settings = {ATTRIBUTES = (Public, ); }; };
1724
D316BD4E217F67BC00688E56 /* MPKitOptimizely.h in Headers */ = {isa = PBXBuildFile; fileRef = D316BD4C217F67BC00688E56 /* MPKitOptimizely.h */; settings = {ATTRIBUTES = (Public, ); }; };
1825
D316BD4F217F67BC00688E56 /* MPKitOptimizely.m in Sources */ = {isa = PBXBuildFile; fileRef = D316BD4D217F67BC00688E56 /* MPKitOptimizely.m */; };
19-
D377138D23FEE08E00CF4773 /* mParticle_Apple_SDK.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D377138C23FEE08E00CF4773 /* mParticle_Apple_SDK.framework */; };
20-
D377139123FEE09F00CF4773 /* Optimizely.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D377139023FEE09F00CF4773 /* Optimizely.framework */; };
21-
D37713942404247E00CF4773 /* Optimizely.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D37713932404247E00CF4773 /* Optimizely.framework */; };
22-
D37713962404249200CF4773 /* mParticle_Apple_SDK.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D37713952404249200CF4773 /* mParticle_Apple_SDK.framework */; };
23-
D377139824042B1000CF4773 /* Optimizely.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D37713932404247E00CF4773 /* Optimizely.framework */; };
24-
D377139924042B2200CF4773 /* mParticle_Apple_SDK.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D37713952404249200CF4773 /* mParticle_Apple_SDK.framework */; };
25-
D377139B24042B2200CF4773 /* OCMock.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D377139A24042B2200CF4773 /* OCMock.framework */; };
2626
D3B8187D2BC6C002001F09BB /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = D3B8187C2BC6C002001F09BB /* PrivacyInfo.xcprivacy */; };
2727
D3B8187E2BC6C002001F09BB /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = D3B8187C2BC6C002001F09BB /* PrivacyInfo.xcprivacy */; };
2828
/* End PBXBuildFile section */
2929

3030
/* Begin PBXContainerItemProxy section */
31+
53DE7F902BEA8AE700907F6D /* PBXContainerItemProxy */ = {
32+
isa = PBXContainerItemProxy;
33+
containerPortal = D316BD29217F670500688E56 /* Project object */;
34+
proxyType = 1;
35+
remoteGlobalIDString = D308517D219B2CEC00D1C15A;
36+
remoteInfo = mParticle_Optimizely_tvOS;
37+
};
3138
D3085188219B2CED00D1C15A /* PBXContainerItemProxy */ = {
3239
isa = PBXContainerItemProxy;
3340
containerPortal = D316BD29217F670500688E56 /* Project object */;
@@ -45,6 +52,9 @@
4552
/* End PBXContainerItemProxy section */
4653

4754
/* Begin PBXFileReference section */
55+
53DE7F7E2BEA868400907F6D /* OCMock.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = OCMock.xcframework; path = Carthage/Build/OCMock.xcframework; sourceTree = "<group>"; };
56+
53DE7F7F2BEA868400907F6D /* mParticle_Apple_SDK.xcframework */ = {isa = PBXFileReference; expectedSignature = "AppleDeveloperProgram:DLD43Y3TRP:mParticle, inc"; lastKnownFileType = wrapper.xcframework; name = mParticle_Apple_SDK.xcframework; path = Carthage/Build/mParticle_Apple_SDK.xcframework; sourceTree = "<group>"; };
57+
53DE7F802BEA868400907F6D /* Optimizely.xcframework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcframework; name = Optimizely.xcframework; path = Carthage/Build/Optimizely.xcframework; sourceTree = "<group>"; };
4858
D308517E219B2CEC00D1C15A /* mParticle_Optimizely_tvOS.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = mParticle_Optimizely_tvOS.framework; sourceTree = BUILT_PRODUCTS_DIR; };
4959
D3085180219B2CEC00D1C15A /* mParticle_Optimizely_tvOS.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = mParticle_Optimizely_tvOS.h; sourceTree = "<group>"; };
5060
D3085181219B2CEC00D1C15A /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
@@ -59,11 +69,6 @@
5969
D316BD42217F670600688E56 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
6070
D316BD4C217F67BC00688E56 /* MPKitOptimizely.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = MPKitOptimizely.h; sourceTree = "<group>"; };
6171
D316BD4D217F67BC00688E56 /* MPKitOptimizely.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = MPKitOptimizely.m; sourceTree = "<group>"; };
62-
D377138C23FEE08E00CF4773 /* mParticle_Apple_SDK.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = mParticle_Apple_SDK.framework; path = Carthage/Build/iOS/mParticle_Apple_SDK.framework; sourceTree = "<group>"; };
63-
D377139023FEE09F00CF4773 /* Optimizely.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Optimizely.framework; path = Carthage/Build/iOS/Optimizely.framework; sourceTree = "<group>"; };
64-
D37713932404247E00CF4773 /* Optimizely.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Optimizely.framework; path = Carthage/Build/tvOS/Optimizely.framework; sourceTree = "<group>"; };
65-
D37713952404249200CF4773 /* mParticle_Apple_SDK.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = mParticle_Apple_SDK.framework; path = Carthage/Build/tvOS/mParticle_Apple_SDK.framework; sourceTree = "<group>"; };
66-
D377139A24042B2200CF4773 /* OCMock.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = OCMock.framework; path = Carthage/Build/tvOS/OCMock.framework; sourceTree = "<group>"; };
6772
D3B8187C2BC6C002001F09BB /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
6873
/* End PBXFileReference section */
6974

@@ -72,27 +77,26 @@
7277
isa = PBXFrameworksBuildPhase;
7378
buildActionMask = 2147483647;
7479
files = (
75-
D37713962404249200CF4773 /* mParticle_Apple_SDK.framework in Frameworks */,
76-
D37713942404247E00CF4773 /* Optimizely.framework in Frameworks */,
80+
53DE7F892BEA8ACD00907F6D /* mParticle_Apple_SDK.xcframework in Frameworks */,
81+
53DE7F8B2BEA8ACD00907F6D /* Optimizely.xcframework in Frameworks */,
7782
);
7883
runOnlyForDeploymentPostprocessing = 0;
7984
};
8085
D3085183219B2CEC00D1C15A /* Frameworks */ = {
8186
isa = PBXFrameworksBuildPhase;
8287
buildActionMask = 2147483647;
8388
files = (
84-
D377139B24042B2200CF4773 /* OCMock.framework in Frameworks */,
85-
D377139924042B2200CF4773 /* mParticle_Apple_SDK.framework in Frameworks */,
86-
D377139824042B1000CF4773 /* Optimizely.framework in Frameworks */,
89+
53DE7F8E2BEA8AE700907F6D /* mParticle_Optimizely_tvOS.framework in Frameworks */,
90+
53DE7F882BEA879A00907F6D /* OCMock.xcframework in Frameworks */,
8791
);
8892
runOnlyForDeploymentPostprocessing = 0;
8993
};
9094
D316BD2E217F670500688E56 /* Frameworks */ = {
9195
isa = PBXFrameworksBuildPhase;
9296
buildActionMask = 2147483647;
9397
files = (
94-
D377139123FEE09F00CF4773 /* Optimizely.framework in Frameworks */,
95-
D377138D23FEE08E00CF4773 /* mParticle_Apple_SDK.framework in Frameworks */,
98+
53DE7F832BEA868400907F6D /* Optimizely.xcframework in Frameworks */,
99+
53DE7F822BEA868400907F6D /* mParticle_Apple_SDK.xcframework in Frameworks */,
96100
);
97101
runOnlyForDeploymentPostprocessing = 0;
98102
};
@@ -101,6 +105,7 @@
101105
buildActionMask = 2147483647;
102106
files = (
103107
D316BD3C217F670600688E56 /* mParticle_Optimizely.framework in Frameworks */,
108+
53DE7F872BEA879900907F6D /* OCMock.xcframework in Frameworks */,
104109
);
105110
runOnlyForDeploymentPostprocessing = 0;
106111
};
@@ -172,11 +177,9 @@
172177
D377138B23FEE08E00CF4773 /* Frameworks */ = {
173178
isa = PBXGroup;
174179
children = (
175-
D377139A24042B2200CF4773 /* OCMock.framework */,
176-
D37713952404249200CF4773 /* mParticle_Apple_SDK.framework */,
177-
D377139023FEE09F00CF4773 /* Optimizely.framework */,
178-
D37713932404247E00CF4773 /* Optimizely.framework */,
179-
D377138C23FEE08E00CF4773 /* mParticle_Apple_SDK.framework */,
180+
53DE7F7F2BEA868400907F6D /* mParticle_Apple_SDK.xcframework */,
181+
53DE7F802BEA868400907F6D /* Optimizely.xcframework */,
182+
53DE7F7E2BEA868400907F6D /* OCMock.xcframework */,
180183
);
181184
name = Frameworks;
182185
sourceTree = "<group>";
@@ -230,12 +233,12 @@
230233
D3085182219B2CEC00D1C15A /* Sources */,
231234
D3085183219B2CEC00D1C15A /* Frameworks */,
232235
D3085184219B2CEC00D1C15A /* Resources */,
233-
D37713972404282100CF4773 /* ShellScript */,
234236
);
235237
buildRules = (
236238
);
237239
dependencies = (
238240
D3085189219B2CED00D1C15A /* PBXTargetDependency */,
241+
53DE7F912BEA8AE700907F6D /* PBXTargetDependency */,
239242
);
240243
name = mParticle_Optimizely_tvOSTests;
241244
productName = mParticle_Optimizely_tvOSTests;
@@ -355,32 +358,6 @@
355358
};
356359
/* End PBXResourcesBuildPhase section */
357360

358-
/* Begin PBXShellScriptBuildPhase section */
359-
D37713972404282100CF4773 /* ShellScript */ = {
360-
isa = PBXShellScriptBuildPhase;
361-
buildActionMask = 2147483647;
362-
files = (
363-
);
364-
inputFileListPaths = (
365-
);
366-
inputPaths = (
367-
"$(SRCROOT)/Carthage/Build/tvOS/OCMock.framework",
368-
"$(SRCROOT)/Carthage/Build/tvOS/Optimizely.framework",
369-
"$(SRCROOT)/Carthage/Build/tvOS/mParticle_Apple_SDK.framework",
370-
);
371-
outputFileListPaths = (
372-
);
373-
outputPaths = (
374-
"$(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)/OCMock.framework",
375-
"$(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)/mParticle_Apple_SDK.framework",
376-
"$(BUILT_PRODUCTS_DIR)/$(FRAMEWORKS_FOLDER_PATH)/Optimizely.framework",
377-
);
378-
runOnlyForDeploymentPostprocessing = 0;
379-
shellPath = /bin/sh;
380-
shellScript = "/usr/local/bin/carthage copy-frameworks\n";
381-
};
382-
/* End PBXShellScriptBuildPhase section */
383-
384361
/* Begin PBXSourcesBuildPhase section */
385362
D3085179219B2CEC00D1C15A /* Sources */ = {
386363
isa = PBXSourcesBuildPhase;
@@ -417,6 +394,11 @@
417394
/* End PBXSourcesBuildPhase section */
418395

419396
/* Begin PBXTargetDependency section */
397+
53DE7F912BEA8AE700907F6D /* PBXTargetDependency */ = {
398+
isa = PBXTargetDependency;
399+
target = D308517D219B2CEC00D1C15A /* mParticle_Optimizely_tvOS */;
400+
targetProxy = 53DE7F902BEA8AE700907F6D /* PBXContainerItemProxy */;
401+
};
420402
D3085189219B2CED00D1C15A /* PBXTargetDependency */ = {
421403
isa = PBXTargetDependency;
422404
target = D308517D219B2CEC00D1C15A /* mParticle_Optimizely_tvOS */;
@@ -457,7 +439,6 @@
457439
SDKROOT = appletvos;
458440
SKIP_INSTALL = YES;
459441
TARGETED_DEVICE_FAMILY = 3;
460-
TVOS_DEPLOYMENT_TARGET = 11.4;
461442
};
462443
name = Debug;
463444
};
@@ -488,14 +469,12 @@
488469
SDKROOT = appletvos;
489470
SKIP_INSTALL = YES;
490471
TARGETED_DEVICE_FAMILY = 3;
491-
TVOS_DEPLOYMENT_TARGET = 11.4;
492472
};
493473
name = Release;
494474
};
495475
D3085193219B2CED00D1C15A /* Debug */ = {
496476
isa = XCBuildConfiguration;
497477
buildSettings = {
498-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
499478
CODE_SIGN_STYLE = Automatic;
500479
DEVELOPMENT_TEAM = DLD43Y3TRP;
501480
FRAMEWORK_SEARCH_PATHS = (
@@ -520,7 +499,6 @@
520499
D3085194219B2CED00D1C15A /* Release */ = {
521500
isa = XCBuildConfiguration;
522501
buildSettings = {
523-
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
524502
CODE_SIGN_STYLE = Automatic;
525503
DEVELOPMENT_TEAM = DLD43Y3TRP;
526504
FRAMEWORK_SEARCH_PATHS = (
@@ -594,10 +572,11 @@
594572
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
595573
GCC_WARN_UNUSED_FUNCTION = YES;
596574
GCC_WARN_UNUSED_VARIABLE = YES;
597-
IPHONEOS_DEPLOYMENT_TARGET = 11.4;
575+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
598576
MTL_ENABLE_DEBUG_INFO = YES;
599577
ONLY_ACTIVE_ARCH = YES;
600578
SDKROOT = iphoneos;
579+
TVOS_DEPLOYMENT_TARGET = 10.0;
601580
VERSIONING_SYSTEM = "apple-generic";
602581
VERSION_INFO_PREFIX = "";
603582
};
@@ -649,9 +628,10 @@
649628
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
650629
GCC_WARN_UNUSED_FUNCTION = YES;
651630
GCC_WARN_UNUSED_VARIABLE = YES;
652-
IPHONEOS_DEPLOYMENT_TARGET = 11.4;
631+
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
653632
MTL_ENABLE_DEBUG_INFO = NO;
654633
SDKROOT = iphoneos;
634+
TVOS_DEPLOYMENT_TARGET = 10.0;
655635
VALIDATE_PRODUCT = YES;
656636
VERSIONING_SYSTEM = "apple-generic";
657637
VERSION_INFO_PREFIX = "";
@@ -674,7 +654,6 @@
674654
);
675655
INFOPLIST_FILE = mParticle_Optimizely/Info.plist;
676656
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
677-
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
678657
LD_RUNPATH_SEARCH_PATHS = (
679658
"$(inherited)",
680659
"@executable_path/Frameworks",
@@ -703,7 +682,6 @@
703682
);
704683
INFOPLIST_FILE = mParticle_Optimizely/Info.plist;
705684
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
706-
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
707685
LD_RUNPATH_SEARCH_PATHS = (
708686
"$(inherited)",
709687
"@executable_path/Frameworks",

‎mParticle_Optimizely/PrivacyInfo.xcprivacy‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,8 @@
77
<key>NSPrivacyTrackingDomains</key>
88
<array/>
99
<key>NSPrivacyCollectedDataTypes</key>
10-
<array>
11-
<dict/>
12-
</array>
10+
<array/>
1311
<key>NSPrivacyAccessedAPITypes</key>
14-
<array>
15-
<dict/>
16-
</array>
12+
<array/>
1713
</dict>
1814
</plist>

‎mParticle_OptimizelyTests/mParticle_OptimizelyTests.m‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -626,9 +626,8 @@ - (void)testlogCommerceEventWithCustomNameAndRevenue {
626626

627627
kitInstance.kitApi = mockKitAPI;
628628

629-
[[mockClient expect] trackWithEventKey:@"eCommerce - purchase - Item" userId:OCMOCK_ANY attributes:OCMOCK_ANY eventTags:OCMOCK_ANY error:nil];
630629
[[mockClient expect] trackWithEventKey:@"testMapping" userId:OCMOCK_ANY attributes:OCMOCK_ANY eventTags:[OCMArg checkWithBlock:^BOOL(NSDictionary<NSString *, NSString *> *value) {
631-
return [value[@"revenue"] isEqual:@"1300"];
630+
return [value[@"revenue"] isEqual:@1300];
632631
}] error:nil];
633632

634633
execStatus = [kitInstance logBaseEvent:event];
@@ -687,10 +686,9 @@ - (void)testlogCommerceEventWithCustomNameRevenueAndUserId {
687686

688687
kitInstance.kitApi = mockKitAPI;
689688

690-
[[mockClient expect] trackWithEventKey:@"eCommerce - purchase - Item" userId:OCMOCK_ANY attributes:OCMOCK_ANY eventTags:OCMOCK_ANY error:nil];
691689
[[mockClient expect] trackWithEventKey:@"testMapping" userId:@"User65656" attributes:OCMOCK_ANY eventTags:[OCMArg checkWithBlock:^BOOL(NSDictionary<NSString *, NSString *> *value)
692690
{
693-
return [value[@"revenue"] isEqual:@"1300"];
691+
return [value[@"revenue"] isEqual:@1300];
694692
}] error:nil];
695693

696694
execStatus = [kitInstance logBaseEvent:event];

‎mParticle_Optimizely_tvOSTests/mParticle_Optimizely_tvOSTests.m‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -633,9 +633,8 @@ - (void)testlogCommerceEventWithCustomNameAndRevenue {
633633

634634
kitInstance.kitApi = mockKitAPI;
635635

636-
[[mockClient expect] trackWithEventKey:@"eCommerce - purchase - Item" userId:OCMOCK_ANY attributes:OCMOCK_ANY eventTags:OCMOCK_ANY error:nil];
637636
[[mockClient expect] trackWithEventKey:@"testMapping" userId:OCMOCK_ANY attributes:OCMOCK_ANY eventTags:[OCMArg checkWithBlock:^BOOL(NSDictionary<NSString *, NSString *> *value) {
638-
return [value[@"revenue"] isEqual:@"1300"];
637+
return [value[@"revenue"] isEqual:@1300];
639638
}] error:nil];
640639

641640
execStatus = [kitInstance logBaseEvent:event];
@@ -694,10 +693,9 @@ - (void)testlogCommerceEventWithCustomNameRevenueAndUserId {
694693

695694
kitInstance.kitApi = mockKitAPI;
696695

697-
[[mockClient expect] trackWithEventKey:@"eCommerce - purchase - Item" userId:OCMOCK_ANY attributes:OCMOCK_ANY eventTags:OCMOCK_ANY error:nil];
698696
[[mockClient expect] trackWithEventKey:@"testMapping" userId:@"User65656" attributes:OCMOCK_ANY eventTags:[OCMArg checkWithBlock:^BOOL(NSDictionary<NSString *, NSString *> *value)
699697
{
700-
return [value[@"revenue"] isEqual:@"1300"];
698+
return [value[@"revenue"] isEqual:@1300];
701699
}] error:nil];
702700

703701
execStatus = [kitInstance logBaseEvent:event];

0 commit comments

Comments
 (0)