filename can't be the same as source filename

[hennr]

If you edit tags and save the file without modifying the file name, mp3agic throws an IllegalArgumentException ("Save filename same as source filename")

This is a very common task and should be possible.

[mpatric]

This is a restriction of the OS, not the library. I'm not sure the library should be managing this for you. Save it with a different filename, then rename the original to something else, then rename the new file.

[andymorton]

Hi.
Ive just come across the issue here. I know its closed, but on line 391 of Mp3File, it throws this exception.
Doesnt look like a OS restriction to me...
Any particular reason for that line?

[hennr]

The IllegalArgumentException you are talking about gives the developer the feedback that there is a restriction and you may not use the library this way.

Question is if the lib should work around the restriction or leave it to you as a dev to do so (by saving a second file, removing the old one and rename the new/second file).

[mpatric]

Yes, as hennr says, it's to prevent it failing with an exception thrown by a lower level call. My intention was for the call to Mp3File to behave consistently across platforms. I don't think this library should be doing the file renaming and manipulation. Do you disagree?

[andymorton]

Given that the restriction is at an os-level, in order to make the library work with the same filename, the developer will have to take account of that. I just wondered why there was that line.
As it turns out my os (osx) doesnt like it when that check is commented out, so it seems that I will be doing the File renaming and manipulation anyway!
Thanks for clearing that up!

[ahristov314]

Not an OS issue. See here: #69

Fix here: #202