Handle non-existent check

Author: mpchadwick

lib/jekyll-pre-commit/runner.rb

@@ -28,7 +28,14 @@ def run(site, staged_files)
         end
 
         site.config["pre-commit"].each do |c|
-          o = Object.const_get("Jekyll::PreCommit::Check::" + c["check"]).new
+          begin
+            o = Object.const_get("Jekyll::PreCommit::Check::" + c["check"]).new
+          rescue
+            result[:ok] = false
+            # Skip any other messages so the user focuses on this.
+            result[:message] = ["The check #{c["check"]} does not exist! Please fix your configuration."]
+            break
+          end
           r = o.Check(staged_posts, not_staged_posts, site, c)
           if !r[:ok]
             result[:ok] = false

spec/jekyll-pre-commit_spec.rb

@@ -122,4 +122,15 @@
       expect(result[:messages]).to match_array([])
     end
   end
+
+  context "with a check that doesn't exist" do
+    pre_commit_config = {"check" => "Garbage"}
+    let(:site) { build_site({ 'pre-commit' => [pre_commit_config] }) }
+
+    it "fails with non-existent check message" do
+      result = runner.run(site, ["spec/fixtures/_posts/2017-01-06-no-description.md"])
+      expect(result[:ok]).to eql(false)
+      expect(result[:message]).to match_array(["The check Garbage does not exist! Please fix your configuration."])
+    end
+  end
 end