Unnecessary list comprehension - 'any' can take a generator

hugovk · hugovk · commit 6d458ef021f2 · 2018-05-02T15:14:06.000+03:00
diff --git a/jose/jwk.py b/jose/jwk.py
@@ -110,7 +110,7 @@ def __init__(self, key, algorithm):
             b'ssh-rsa'
         ]
 
-        if any([string_value in key for string_value in invalid_strings]):
+        if any(string_value in key for string_value in invalid_strings):
             raise JWKError(
                 'The specified key is an asymmetric key or x509 certificate and'
                 ' should not be used as an HMAC secret.')

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ def __init__(self, key, algorithm):`
`110`	`110`	`b'ssh-rsa'`
`111`	`111`	`]`
`112`	`112`
`113`		`- if any([string_value in key for string_value in invalid_strings]):`
	`113`	`+ if any(string_value in key for string_value in invalid_strings):`
`114`	`114`	`raise JWKError(`
`115`	`115`	`'The specified key is an asymmetric key or x509 certificate and'`
`116`	`116`	`' should not be used as an HMAC secret.')`