Drop useless parameter

It was here to improve DX on 3.x

Author: greg0ire

phpstan.neon

@@ -11,10 +11,3 @@ parameters:
         -
             message: '~^Match expression does not handle remaining values:~'
             path: src/Persisters/Entity/BasicEntityPersister.php
-
-        # To be removed in 4.0
-
-        -
-            message: '#Negated boolean expression is always false\.#'
-            paths:
-                - src/Mapping/Driver/AttributeDriver.php

src/Mapping/Driver/AttributeDriver.php

@@ -12,15 +12,13 @@
 use Doctrine\Persistence\Mapping\ClassMetadata as PersistenceClassMetadata;
 use Doctrine\Persistence\Mapping\Driver\ColocatedMappingDriver;
 use Doctrine\Persistence\Mapping\Driver\MappingDriver;
-use InvalidArgumentException;
 use ReflectionClass;
 use ReflectionMethod;
 
 use function assert;
 use function class_exists;
 use function constant;
 use function defined;
-use function sprintf;
 
 class AttributeDriver implements MappingDriver
 {
@@ -34,19 +32,9 @@ class AttributeDriver implements MappingDriver
 
     private readonly AttributeReader $reader;
 
-    /**
-     * @param array<string> $paths
-     * @param true          $reportFieldsWhereDeclared no-op, to be removed in 4.0
-     */
-    public function __construct(array $paths, bool $reportFieldsWhereDeclared = true)
+    /** @param array<string> $paths */
+    public function __construct(array $paths)
     {
-        if (! $reportFieldsWhereDeclared) {
-            throw new InvalidArgumentException(sprintf(
-                'The $reportFieldsWhereDeclared argument is no longer supported, make sure to omit it when calling %s.',
-                __METHOD__,
-            ));
-        }
-
         $this->reader = new AttributeReader();
         $this->addPaths($paths);
     }

tests/Tests/ORM/Mapping/AttributeDriverTest.php

@@ -12,7 +12,6 @@
 use Doctrine\ORM\Mapping\MappingAttribute;
 use Doctrine\Persistence\Mapping\Driver\MappingDriver;
 use Doctrine\Tests\ORM\Mapping\Fixtures\AttributeEntityWithNestedJoinColumns;
-use InvalidArgumentException;
 use stdClass;
 
 class AttributeDriverTest extends MappingDriverTestCase
@@ -88,13 +87,6 @@ public function testManyToManyAssociationWithNestedJoinColumns(): void
             $metadata->associationMappings['assoc']->joinTable->inverseJoinColumns,
         );
     }
-
-    public function testItThrowsWhenSettingReportFieldsWhereDeclaredToFalse(): void
-    {
-        $this->expectException(InvalidArgumentException::class);
-
-        new AttributeDriver([], false);
-    }
 }
 
 #[ORM\Entity]