Added eslint-tests based on sane and fixed codebase.

Author: markusdap

.eslintrc

@@ -0,0 +1,31 @@
+{
+  "rules" : {
+    "strict"                           : 0,
+    "no-underscore-dangle"             : 0,
+    "no-multi-spaces"                  : 0,
+    "key-spacing"                      : 0,
+    "no-shadow"                        : 0,
+    "consistent-return"                : 2,
+    "no-use-before-define"             : 2,
+    "new-parens"                       : 2,
+    "no-cond-assign"                   : 2,
+    "space-after-keywords"             : 2,
+    "space-infix-ops"                  : 2,
+    "comma-dangle"                     : [2, "never"],
+    "no-multiple-empty-lines"          : [2, {"max": 2}],
+    "quotes"                           : [2, "single"],
+    "eqeqeq"                           : [2, "smart"],
+    "wrap-iife"                        : [2, "inside"],
+    "indent"                           : [2, 2],
+    "brace-style"                      : [2, "1tbs"],
+    "spaced-line-comment"              : [2, "always", {"exceptions":["-","+"]}],
+    "space-before-function-parentheses": [2, {
+                                            "anonymous" : "always",
+                                            "named" : "never"
+                                          }]
+  },
+  "env": {
+    "node": true,
+    "es6" : true
+  }
+}

bin/index.js

@@ -19,11 +19,13 @@ var scope = {
   },
 
   // For the NEW generator we're generating:
-  generatorName: process.argv[ 2 ],
+  generatorName: process.argv[ 2 ]
 };
 
 sailsgen( scope, function ( err ) {
-  if ( err ) throw err;
+  if ( err ) {
+    throw err;
+  }
 
   // It worked.
   console.log( 'Done.' );

lib/before.js

@@ -2,8 +2,7 @@
  * Module dependencies
  */
 
-var util = require( 'util' ),
-  _ = require( 'lodash' );
+var _ = require( 'lodash' );
 
 // Make _.defaults recursive
 _.defaults = require( 'merge-defaults' );

lib/index.js

@@ -18,35 +18,35 @@ module.exports = {
 
   targets: {
     './': {
-      exec: function( scope, cb ) {
+      exec: function ( scope, cb ) {
         // get the "flavor" of bluepritns
         templateDir = templateDir + '/' + scope.flavor;
         console.log( 'Running generator (sails-generate-ember-blueprints) @ `' + scope.rootPath + '`...' );
 
         // check for previous installation
         if ( fs.existsSync( scope.rootPath + '/api/blueprints' ) && fs.existsSync( scope.rootPath + '/api/services/Ember.js' ) && !scope.force ) {
           console.log( scope );
-          return cb( new Error( "Looks like the blueprints are already installed. Just in case you made some changes to them, we're stopping here. If you want to override the existing files and do a fresh install use the '--force' option." ) );
+          return cb( new Error( 'Looks like the blueprints are already installed. Just in case you made some changes to them, we\'re stopping here. If you want to override the existing files and do a fresh install use the \'--force\' option.' ) );
         }
 
         // copy blueprint and service files
         console.log( 'Installing "' + scope.flavor + '" of blueprints.' );
 
         // create blueprints directory if it does not exist
-        if( ! fs.existsSync( scope.rootPath + '/api/blueprints' ) ) {
+        if ( !fs.existsSync( scope.rootPath + '/api/blueprints' ) ) {
           fs.mkdirSync( scope.rootPath + '/api/blueprints' );
         }
 
-        ['create', 'destroy', 'find', 'findone', 'populate', 'update'].forEach(function(blueprint) {
-          fs.writeFileSync(scope.rootPath + '/api/blueprints/' + blueprint + '.js', "module.exports = require('sails-generate-ember-blueprints/templates/" + scope.flavor + "/api/blueprints/" + blueprint + ".js');\n");
+        ['create', 'destroy', 'find', 'findone', 'populate', 'update'].forEach(function (blueprint) {
+          fs.writeFileSync(scope.rootPath + '/api/blueprints/' + blueprint + '.js', 'module.exports = require(\'sails-generate-ember-blueprints/templates/' + scope.flavor + '/api/blueprints/' + blueprint + '.js\');\n');
         });
 
-        fs.writeFileSync(scope.rootPath + '/api/services/Ember.js', "module.exports = require('sails-generate-ember-blueprints/templates/" + scope.flavor + "/api/services/Ember.js');\n");
+        fs.writeFileSync(scope.rootPath + '/api/services/Ember.js', 'module.exports = require(\'sails-generate-ember-blueprints/templates/' + scope.flavor + '/api/services/Ember.js\');\n');
 
         // @todo: check configuration options? Would be great if we could peek into the Sails project configuration and notify the developer about necessary changes
 
         cb();
       }
-    },
+    }
   }
 };

package.json

@@ -7,6 +7,9 @@
     "email": "[email protected]"
   },
   "main": "lib/index.js",
+  "scripts": {
+    "test": "node tests/runner"
+  },
   "homepage": "https://github.com/mphasize/sails-generate-ember-blueprints",
   "repository": {
     "type": "git",
@@ -30,6 +33,9 @@
     "merge-defaults": "^0.2.1"
   },
   "devDependencies": {
+    "glob": "^5.0.5",
+    "mocha": "^2.2.4",
+    "mocha-eslint": "^0.1.4",
     "sails-generate": "*"
   },
   "sailsGenerator": {

tests/.eslintrc

@@ -0,0 +1,5 @@
+{
+  "env": {
+    "mocha": true
+  }
+}

tests/runner.js

@@ -0,0 +1,36 @@
+/*eslint no-process-exit:0*/
+'use strict';
+
+var glob  = require('glob');
+var Mocha = require('mocha');
+
+var mocha = new Mocha({
+  // For some reason, tests take a long time on Windows (or at least AppVeyor)
+  timeout: (process.platform === 'win32') ? 30000 : 10000,
+  reporter: 'spec'
+});
+
+// Determine which tests to run based on argument passed to runner
+var arg = process.argv[2];
+var root;
+var files = '/**/*-test.js';
+if (!arg) {
+  root = 'tests/{unit,acceptance}';
+} else if (arg === 'lint') {
+  root = 'tests/unit';
+  files = '/lint-test.js';
+} else {
+  root = 'tests/{unit,acceptance}';
+}
+
+function addFiles(mocha, files) {
+  glob.sync(root + files).forEach(mocha.addFile.bind(mocha));
+}
+
+addFiles(mocha, files);
+
+mocha.run(function (failures) {
+  process.on('exit', function () {
+    process.exit(failures);
+  });
+});

tests/unit/eslint-test.js

@@ -0,0 +1,11 @@
+'use strict';
+
+var lint = require('mocha-eslint');
+
+var paths = [
+  'bin/index.js',
+  'lib',
+  'tests'
+];
+
+lint(paths);