File tree Expand file tree Collapse file tree 1 file changed +35
-0
lines changed Expand file tree Collapse file tree 1 file changed +35
-0
lines changed Original file line number Diff line number Diff line change 1+ commit ec1c2bb8bf56bb7471fc537c527d8d8dffeec471
2+ Author: Hui Zhou <
[email protected] >
3+ Date: Tue Aug 24 20:06:27 2021 -0500
4+
5+ ch4/ofi: cleanup cacheline alignment
6+
7+ The extra symbol MPIDI_OFI_CACHELINE_SIZE is not needed. Just use
8+ MPL_CACHELINE_SIZE.
9+
10+ Drop the useless alignment attribute on the whole struct. What we wanted
11+ is to set alignment on one of its member.
12+
13+ diff --git a/src/mpid/ch4/netmod/ofi/ofi_types.h b/src/mpid/ch4/netmod/ofi/ofi_types.h
14+ index d3a27de515..4bbf500f4c 100644
15+ --- a/src/mpid/ch4/netmod/ofi/ofi_types.h
16+ +++ b/src/mpid/ch4/netmod/ofi/ofi_types.h
17+ @@ -30,7 +30,6 @@
18+ #define MPIDI_OFI_DEFAULT_SHORT_SEND_SIZE (16 * 1024)
19+ #define MPIDI_OFI_MAX_NUM_AM_BUFFERS (8)
20+ #define MPIDI_OFI_AM_BUFF_SZ (1 * 1024 * 1024)
21+ -#define MPIDI_OFI_CACHELINE_SIZE (MPL_CACHELINE_SIZE)
22+ #define MPIDI_OFI_IOV_MAX (32)
23+ #define MPIDI_OFI_AM_HDR_POOL_CELL_SIZE (1024)
24+ #define MPIDI_OFI_AM_HDR_POOL_NUM_CELLS_PER_CHUNK (1024)
25+ @@ -272,8 +271,8 @@ typedef struct {
26+
27+ typedef union {
28+ MPID_Thread_mutex_t m;
29+ - char cacheline[MPIDI_OFI_CACHELINE_SIZE];
30+ -} MPIDI_OFI_cacheline_mutex_t MPL_ATTR_ALIGNED(MPIDI_OFI_CACHELINE_SIZE);
31+ + char cacheline[MPL_CACHELINE_SIZE];
32+ +} MPIDI_OFI_cacheline_mutex_t;
33+
34+ typedef struct {
35+ unsigned enable_av_table:1;
You can’t perform that action at this time.
0 commit comments