Canonical use of environment variables

Author: dalcinl

.github/workflows/cd-wheel.yml

@@ -164,8 +164,6 @@ jobs:
           bash {project}/cibw-patch-cmd.sh
         CIBW_TEST_COMMAND: >-
           bash {project}/cibw-check-mpi.sh
-        CIBW_ENVIRONMENT_PASS: >-
-          MPINAME RELEASE
         CIBW_ENVIRONMENT_LINUX: >-
           SOURCE="/project/package/source"
           WORKDIR="/project/package/workdir"
@@ -189,8 +187,9 @@ jobs:
     - id: upload
       uses: actions/upload-artifact@v4
       with:
-        name: "wheel-${{ inputs.mpiname }}-\
-              ${{ inputs.version || 'latest' }}-\
+        name: "wheel-\
+              ${{ steps.bootstrap.outputs.mpiname }}-\
+              ${{ steps.bootstrap.outputs.version }}-\
               ${{ matrix.os }}-${{ matrix.arch }}"
         path: wheelhouse/*.whl
 
@@ -202,7 +201,9 @@ jobs:
         # ./wheel-test.sh
         test $(uname) = Linux && runner=(
         docker run
-        -e MPINAME=${{ inputs.mpiname }}
+        -e MPINAME=${{ steps.bootstrap.outputs.mpiname }}
+        -e VERSION=${{ steps.bootstrap.outputs.version }}
+        -e RELEASE=${{ steps.bootstrap.outputs.release }}
         -v $(pwd):/${{ github.workspace }}
         -w ${{ github.workspace }}
         --platform linux/${{

bootstrap.sh

@@ -7,6 +7,7 @@ case "$mpiname" in
     openmpi) version=5.0.7 ;;
 esac
 version=${VERSION:-$version}
+release=${RELEASE:-}
 
 ucxversion=1.18.0
 ofiversion=1.22.0
@@ -73,11 +74,13 @@ if test ! -d "$SOURCE"; then
     echo writing package metadata ...
     echo "Name: $mpiname" > "$PACKAGE/METADATA"
     echo "Version: $version" >> "$PACKAGE/METADATA"
+    echo "Release: $release" >> "$PACKAGE/METADATA"
 else
     echo reusing directory "$SOURCE"...
     check() { test "$(awk "/$1/"'{print $2}' "$PACKAGE/METADATA")" = "$2"; }
-    check Name    "$mpiname" || (echo not "$mpiname-$version"!!! && exit 1)
-    check Version "$version" || (echo not "$mpiname-$version"!!! && exit 1)
+    check Name    "$mpiname" || (echo "error: mpiname!=$mpiname" && exit 1)
+    check Version "$version" || (echo "error: version!=$version" && exit 1)
+    check Release "$release" || (echo "error: release!=$release" && exit 1)
 fi
 
 if test "$(uname)" = "Linux"; then
@@ -188,3 +191,9 @@ for license in "${otherlicenses[@]}"; do
     echo copying "$module" license file...
     cp "$license" "$PACKAGE/LICENSE.$module"
 done
+
+if test -n "${GITHUB_OUTPUT+x}"; then
+    echo "mpiname=${mpiname}" >> $GITHUB_OUTPUT
+    echo "version=${version}" >> $GITHUB_OUTPUT
+    echo "release=${release}" >> $GITHUB_OUTPUT
+fi

cibw-check-mpi.sh

@@ -1,11 +1,13 @@
 #!/bin/bash
 set -euo pipefail
 
-mpiname="${MPINAME:-mpich}"
-case "$mpiname" in
-    mpich)   version=$(mpichversion --version | cut -d':' -f 2) ;;
-    openmpi) version=$(ompi_info --version | head -n 1 | cut -d'v' -f 2) ;;
-esac
+if command -v mpichversion > /dev/null; then
+    mpiname=mpich
+    version=$(mpichversion --version | cut -d':' -f 2)
+elif command -v ompi_info > /dev/null; then
+    mpiname=openmpi
+    version=$(ompi_info --version | head -n 1 | cut -d'v' -f 2)
+fi
 
 tempdir="$(mktemp -d)"
 trap 'rm -rf $tempdir' EXIT

package/setup.py

@@ -24,11 +24,12 @@ def get_tag(self):
     metadata = re.search(r"""
     Name:\s*(?P<name>.*)\n
     Version:\s*(?P<version>.*)\n
+    Release:\s*(?P<release>.*)\n
     """, fobj.read(), re.VERBOSE).groupdict()
 
 mpiname = metadata["name"]
 version = metadata["version"]
-release = os.environ.get("RELEASE", "")
+release = metadata["release"]
 if release:
     version += f".post{release}"
 

wheel-build.sh

@@ -16,7 +16,7 @@ export CIBW_ARCHS=$ARCHLIST
 export CIBW_BEFORE_ALL='bash {project}/cibw-build-mpi.sh'
 export CIBW_BEFORE_BUILD='bash {project}/cibw-patch-cmd.sh'
 export CIBW_TEST_COMMAND='bash {project}/cibw-check-mpi.sh'
-export CIBW_ENVIRONMENT_PASS='MPINAME RELEASE SOURCE WORKDIR DESTDIR'
+export CIBW_ENVIRONMENT_PASS='SOURCE WORKDIR DESTDIR'
 export CIBW_MANYLINUX_AARCH64_IMAGE=manylinux2014
 export CIBW_MANYLINUX_X86_64_IMAGE=manylinux2014