Skip to content

[CLARIFICATION] recordingsites kwargs in biophysics_fitting.simulator.run_fun #454

@bgmeulem

Description

@bgmeulem

biophysics_fitting.simulator.run_fun accepts recordingsites kwarg. This is added to the sim parameters. however, the consequent function call scp.init_neuron_run does not need or do anything with this, and scp_init_neuron_run does not return the simulation parameters either. In other words, the recordingSites kwargs is added to a dict, but this key is consequently ignored and the dict is not returned.

I believe NEURON simply fills the recording sites with voltage data, but there is no need to pass this to scp.init_neuron_run

I propose to keep the keyword argument for API stability, and in case we ever extend it and actually do need the recording sites, but simultaneously warn or inform the user that this kwarg is not necessary, and even ignored right now, as to not confuse the user (I am the user, I was confused)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions