Skip to content

Commit e5a1889

Browse files
change: [DPS-36289] - Logs, mark Log Path field as optional (linode#13338)
1 parent 3754c21 commit e5a1889

File tree

7 files changed

+25
-7
lines changed

7 files changed

+25
-7
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Changed
3+
---
4+
5+
Logs - (optional) text added to Log Path Prefix field label ([#13338](https://github.com/linode/manager/pull/13338))

packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,9 @@ describe('DestinationCreate', () => {
6868
await userEvent.type(accessKeyIDInput, 'Test');
6969
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
7070
await userEvent.type(secretAccessKeyInput, 'Test');
71-
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
71+
const logPathPrefixInput = screen.getByLabelText(
72+
'Log Path Prefix (optional)'
73+
);
7274
await userEvent.type(logPathPrefixInput, 'Test');
7375

7476
expect(destinationNameInput).toHaveValue('Test');
@@ -101,7 +103,9 @@ describe('DestinationCreate', () => {
101103
expect(samplePath).toBeInTheDocument();
102104
});
103105
// Type the test value inside the input
104-
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
106+
const logPathPrefixInput = screen.getByLabelText(
107+
'Log Path Prefix (optional)'
108+
);
105109

106110
await userEvent.type(logPathPrefixInput, 'test');
107111
// sample path should be created based on *log path* value
@@ -218,7 +222,9 @@ describe('DestinationCreate', () => {
218222
await userEvent.type(accessKeyIDInput, 'Test');
219223
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
220224
await userEvent.type(secretAccessKeyInput, 'Test');
221-
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
225+
const logPathPrefixInput = screen.getByLabelText(
226+
'Log Path Prefix (optional)'
227+
);
222228
await userEvent.type(logPathPrefixInput, 'Test');
223229
};
224230

packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe('DestinationEdit', () => {
5555
assertInputHasValue('Bucket', 'destinations-bucket-name');
5656
assertInputHasValue('Access Key ID', 'Access Id');
5757
assertInputHasValue('Secret Access Key', '');
58-
assertInputHasValue('Log Path Prefix', 'file');
58+
assertInputHasValue('Log Path Prefix (optional)', 'file');
5959
});
6060

6161
describe('given Test Connection and Edit Destination buttons', () => {

packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({
140140
label="Log Path Prefix"
141141
onBlur={field.onBlur}
142142
onChange={(value) => field.onChange(value)}
143+
optional
143144
placeholder="Prefix for log storage path"
144145
sx={{ maxWidth: 416 }}
145146
value={field.value}

packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,9 @@ describe('StreamFormDelivery', () => {
249249
);
250250

251251
// Type the test value inside the input
252-
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
252+
const logPathPrefixInput = screen.getByLabelText(
253+
'Log Path Prefix (optional)'
254+
);
253255
await userEvent.type(logPathPrefixInput, 'Test');
254256

255257
expect(logPathPrefixInput.getAttribute('value')).toEqual('Test');

packages/manager/src/features/Delivery/Streams/StreamForm/StreamCreate.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ describe('StreamCreate', () => {
6363
await userEvent.type(accessKeyIDInput, 'Test');
6464
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
6565
await userEvent.type(secretAccessKeyInput, 'Test');
66-
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
66+
const logPathPrefixInput = screen.getByLabelText(
67+
'Log Path Prefix (optional)'
68+
);
6769
await userEvent.type(logPathPrefixInput, 'Test');
6870
};
6971

packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,9 @@ describe('StreamEdit', () => {
104104
await userEvent.type(accessKeyIDInput, 'Test');
105105
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
106106
await userEvent.type(secretAccessKeyInput, 'Test');
107-
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
107+
const logPathPrefixInput = screen.getByLabelText(
108+
'Log Path Prefix (optional)'
109+
);
108110
await userEvent.type(logPathPrefixInput, 'Test');
109111
};
110112

0 commit comments

Comments
 (0)