ProblemYaml & ProblemsYamlEntry: show more paths in warnings

Author: mpsijm

bin/contest.py

@@ -59,21 +59,25 @@ def dict(self) -> dict[str, object]:
 
 
 class ProblemsYamlEntry:
-    def __init__(self, yaml_data: dict[object, object]) -> None:
+    def __init__(self, yaml_data: dict[object, object], index: int) -> None:
         self.ok = False
         parser = YamlParser("problems.yaml", yaml_data)
 
         def get_hex(rgb: Optional[str]) -> Optional[str]:
             if rgb is None:
                 return None
             if not rgb.startswith("#"):
-                error(f"invalid rgb value {rgb} in problems.yaml. SKIPPED")
+                error(
+                    f"invalid rgb value '{rgb}' for problem {index} (id: {self.id}) in problems.yaml. SKIPPED"
+                )
                 return None
             hex_part = rgb[1:].lower()
             if len(hex_part) == 3:
                 hex_part = "".join(c * 2 for c in hex_part)
             if len(hex_part) != 6 or any(c not in string.hexdigits for c in hex_part):
-                error(f"invalid rgb value {rgb} in problems.yaml. SKIPPED")
+                error(
+                    f"invalid rgb value '{rgb}' for problem {index} (id: {self.id}) in problems.yaml. SKIPPED"
+                )
                 return None
             return hex_part
 
@@ -89,23 +93,27 @@ def get_hex(rgb: Optional[str]) -> Optional[str]:
         self.name: dict[str, str] = {}
         for lang, name in names.items():
             if not isinstance(lang, str):
-                warn(f"invalid language '{lang}' in problems.yaml. SKIPPED.")
+                warn(
+                    f"invalid language '{lang}' for problem {index} (id: {self.id}) in problems.yaml. SKIPPED."
+                )
             elif not isinstance(name, str):
-                warn(f"incompatible value for language '{lang}' in problems.yaml. SKIPPED.")
+                warn(
+                    f"incompatible value for language '{lang}' for problem {index} (id: {self.id}) in problems.yaml. SKIPPED."
+                )
             else:
                 self.name[lang] = name
         self.time_limit: Optional[float] = parser.extract_optional("time_limit", float)
         if self.time_limit is not None and not self.time_limit > 0:
             error(
-                f"value for 'time_limit' in problems.yaml should be > 0 but is {self.time_limit}. SKIPPED"
+                f"value for 'time_limit' for problem {index} (id: {self.id}) in problems.yaml should be > 0 but is {self.time_limit}. SKIPPED"
             )
             self.time_limit = None
 
         # contains remaining proper keys
         self._yaml = {k: v for k, v in parser.yaml.items() if isinstance(k, str) and v is not None}
         for key in parser.yaml:
             if key not in self._yaml:
-                warn(f"invalid problems.yaml key: {key} in {self.id}")
+                warn(f"invalid problems.yaml key: {key} for problem {index} (id: {self.id})")
 
         self.ok = parser.errors == 0
 
@@ -145,15 +153,15 @@ def problems_yaml() -> Sequence[ProblemsYamlEntry]:
 
     problems = []
     labels: dict[str, str] = {}
-    for yaml_data in raw_yaml:
+    for i, yaml_data in enumerate(raw_yaml):
         if not isinstance(yaml_data, dict):
             error("entries in problems.yaml must be dicts.")
             continue
-        problem = ProblemsYamlEntry(yaml_data)
+        problem = ProblemsYamlEntry(yaml_data, i)
         if not problem.ok:
             continue
         if problem.label in labels:
-            error(f"lebal {problem.label} found twice in problems.yaml")
+            error(f"label {problem.label} found twice in problems.yaml")
             continue
         labels[problem.label] = problem.id
         if not Path(problem.id).is_dir():

bin/problem.py

@@ -119,7 +119,9 @@ def extract_optional_persons(source: YamlParser, key: str) -> list[Person]:
         self.translators = {}
         for lang in list(translators.yaml.keys()):
             if not isinstance(lang, str):
-                warn(f"invalid language '{lang}' in problem.yaml. SKIPPED.")
+                warn(
+                    f"invalid language `{lang}` for {translators.parent_str} in problem.yaml. SKIPPED."
+                )
             else:
                 self.translators[lang] = extract_optional_persons(translators, lang)
 
@@ -322,9 +324,9 @@ def __init__(
         self.constants: dict[str, str] = {}
         for key, value in constants.items():
             if not isinstance(key, str) or not config.COMPILED_CONSTANT_NAME_REGEX.fullmatch(key):
-                warn(f"invalid constant name: {key}. SKIPPED.")
+                warn(f"invalid constant name `{key}` for `constants` in problem.yaml. SKIPPED.")
             elif not isinstance(value, (str, int, float)):
-                warn(f"invalid constant type for: {key}. SKIPPED.")
+                warn(f"invalid constant type for `constants.{key}` in problem.yaml. SKIPPED.")
             else:
                 self.constants[key] = str(value)
 

test/yaml/problem/invalid.yaml

@@ -217,6 +217,23 @@ yaml:
     authors:
       - foo: "bar"
 warn: "found unknown problem.yaml key: foo in `credits.authors[0]`"
+---
+yaml:
+  problem_format_version: 2025-09
+  name: Invalid key type in credits.authors list
+  credits:
+    authors:
+      - 42: "bar"
+warn: "invalid problem.yaml key: 42 in `credits.authors[0]`"
+---
+yaml:
+  problem_format_version: 2025-09
+  name: Invalid key type in credits.translators list
+  credits:
+    translators:
+      en:
+        - 42: "bar"
+warn: "invalid problem.yaml key: 42 in `credits.translators.en[0]`"
 
 ---
 # Source