Skip to content

Commit 1e9d08c

Browse files
committed
Revert "fix: Enable runtime calls to mp_units::inverse() on Clang 18-20"
This reverts commit c78f31f.
1 parent 986be7e commit 1e9d08c

File tree

2 files changed

+1
-28
lines changed

2 files changed

+1
-28
lines changed

src/core/include/mp-units/bits/hacks.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ MP_UNITS_DIAGNOSTIC_POP
122122

123123
#endif
124124

125-
#if defined MP_UNITS_COMP_CLANG && MP_UNITS_COMP_CLANG < 21
125+
#if defined MP_UNITS_COMP_CLANG && MP_UNITS_COMP_CLANG < 17
126126

127127
#define MP_UNITS_CONSTEVAL constexpr
128128

test/runtime/math_test.cpp

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -589,31 +589,4 @@ TEST_CASE("math operations", "[math]")
589589
REQUIRE_THAT(atan2(1. * isq::length[km], 1000. * isq::length[m]), AlmostEquals(45. * angle[deg]));
590590
}
591591
}
592-
593-
SECTION("inverse functions")
594-
{
595-
SECTION("inverse of time quantity returns frequency")
596-
{
597-
auto period = 2.0 * isq::time[s];
598-
auto frequency = inverse<si::hertz>(period);
599-
REQUIRE(frequency == 0.5 * isq::frequency[Hz]);
600-
}
601-
602-
SECTION("inverse works with runtime values")
603-
{
604-
// Test the specific case that fails with consteval
605-
double runtime_value = 3.0;
606-
auto period = runtime_value * isq::time[s];
607-
auto frequency = inverse<si::hertz>(period);
608-
auto expected = (1.0/3.0) * isq::frequency[Hz];
609-
REQUIRE_THAT(frequency, AlmostEquals(expected));
610-
}
611-
612-
SECTION("inverse with different input units")
613-
{
614-
auto period_ms = 500.0 * isq::time[ms];
615-
auto frequency = inverse<si::hertz>(period_ms);
616-
REQUIRE(frequency == 2.0 * isq::frequency[Hz]);
617-
}
618-
}
619592
}

0 commit comments

Comments
 (0)