feat: 💥 Celsius_temperature removed from ISQ

Author: mpusz

docs/examples/kalman_filter.md

@@ -335,7 +335,7 @@ Where:
 === "Example 8: Dynamic System"
 
     ```cpp
-    using qp = quantity_point<isq::Celsius_temperature[deg_C]>;
+    using qp = quantity_point<deg_C>;
     using estimate = kalman::system_state_estimate<qp>;
 
     const quantity process_noise_variance = delta<pow<2>(deg_C)>(0.15);

docs/users_guide/framework_basics/design_overview.md

@@ -378,5 +378,5 @@ For example:
   the previous example:
 
   ```cpp
-  constexpr auto room_reference_temperature = ice_point + delta<isq::Celsius_temperature[deg_C]>(21);
+  constexpr auto room_reference_temperature = ice_point + delta<deg_C>(21);
   ```

example/kalman_filter/kalman_filter-example_6.cpp

@@ -61,7 +61,7 @@ void print(auto iteration, QP measured, K gain, kalman::system_state_estimate<QP
 int main()
 {
   using namespace mp_units::si::unit_symbols;
-  using qp = quantity_point<isq::Celsius_temperature[deg_C]>;
+  using qp = quantity_point<deg_C>;
   using estimate = kalman::system_state_estimate<qp>;
   using state = estimate::state_type;
 

example/kalman_filter/kalman_filter-example_7.cpp

@@ -61,7 +61,7 @@ void print(auto iteration, QP measured, K gain, kalman::system_state_estimate<QP
 int main()
 {
   using namespace mp_units::si::unit_symbols;
-  using qp = quantity_point<isq::Celsius_temperature[deg_C]>;
+  using qp = quantity_point<deg_C>;
   using estimate = kalman::system_state_estimate<qp>;
   using state = estimate::state_type;
 

example/kalman_filter/kalman_filter-example_8.cpp

@@ -61,7 +61,7 @@ void print(auto iteration, QP measured, K gain, kalman::system_state_estimate<QP
 int main()
 {
   using namespace mp_units::si::unit_symbols;
-  using qp = quantity_point<isq::Celsius_temperature[deg_C]>;
+  using qp = quantity_point<deg_C>;
   using estimate = kalman::system_state_estimate<qp>;
   using state = estimate::state_type;
 

src/systems/include/mp-units/systems/isq/thermodynamics.h

@@ -37,7 +37,8 @@
 MP_UNITS_EXPORT
 namespace mp_units::isq {
 
-QUANTITY_SPEC(Celsius_temperature, thermodynamic_temperature);  // TODO should we account for T0 here?
+// Celsius_temperature is defined in ISQ but explicitly not supported (depends on SI units, breaks non-negativity)
+// QUANTITY_SPEC(Celsius_temperature, thermodynamic_temperature);
 QUANTITY_SPEC(linear_expansion_coefficient, inverse(length) * (length / thermodynamic_temperature));
 QUANTITY_SPEC(cubic_expansion_coefficient, inverse(volume) * (volume / thermodynamic_temperature));
 QUANTITY_SPEC(relative_pressure_coefficient, inverse(pressure) * (pressure / thermodynamic_temperature));

test/static/isq_test.cpp

@@ -164,7 +164,6 @@ static_assert(verify(isq::action, real_scalar, J* s, kg* m2 / s));
 
 // thermodynamics
 static_assert(verify(isq::thermodynamic_temperature, real_scalar, K));
-static_assert(verify(isq::Celsius_temperature, real_scalar, deg_C));
 static_assert(verify(isq::linear_expansion_coefficient, real_scalar, one / K));
 static_assert(verify(isq::cubic_expansion_coefficient, real_scalar, one / K));
 static_assert(verify(isq::relative_pressure_coefficient, real_scalar, one / K));

test/static/quantity_point_test.cpp

@@ -309,21 +309,6 @@ static_assert(unit_for<quantity_point<isq::thermodynamic_temperature[si::kelvin]
 static_assert(reference_for<quantity_point<isq::thermodynamic_temperature[si::kelvin], si::absolute_zero>> ==
               isq::thermodynamic_temperature[si::kelvin]);
 
-static_assert(quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>::reference ==
-              isq::Celsius_temperature[si::kelvin]);
-static_assert(quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>::quantity_spec ==
-              isq::Celsius_temperature);
-static_assert(quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>::dimension ==
-              isq::dim_thermodynamic_temperature);
-static_assert(quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>::unit == si::kelvin);
-static_assert(is_of_type<quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>::point_origin,
-                         struct si::absolute_zero>);
-static_assert(is_of_type<quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>::absolute_point_origin,
-                         struct si::absolute_zero>);
-static_assert(unit_for<quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>> == si::kelvin);
-static_assert(reference_for<quantity_point<isq::Celsius_temperature[si::kelvin], si::absolute_zero>> ==
-              isq::Celsius_temperature[si::kelvin]);
-
 static_assert(quantity_point<si::degree_Celsius, si::ice_point>::reference == si::degree_Celsius);
 static_assert(quantity_point<si::degree_Celsius, si::ice_point>::quantity_spec ==
               kind_of<isq::thermodynamic_temperature>);
@@ -335,22 +320,24 @@ static_assert(
 static_assert(unit_for<quantity_point<si::degree_Celsius, si::ice_point>> == si::degree_Celsius);
 static_assert(reference_for<quantity_point<si::degree_Celsius, si::ice_point>> == si::degree_Celsius);
 
-static_assert(quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>::reference ==
-              isq::Celsius_temperature[si::degree_Celsius]);
-static_assert(quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>::quantity_spec ==
-              isq::Celsius_temperature);
-static_assert(quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>::dimension ==
+static_assert(quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>::reference ==
+              isq::thermodynamic_temperature[si::degree_Celsius]);
+static_assert(quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>::quantity_spec ==
+              isq::thermodynamic_temperature);
+static_assert(quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>::dimension ==
               isq::dim_thermodynamic_temperature);
-static_assert(quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>::unit == si::degree_Celsius);
-static_assert(is_of_type<quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>::point_origin,
-                         struct si::ice_point>);
+static_assert(quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>::unit ==
+              si::degree_Celsius);
+static_assert(
+  is_of_type<quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>::point_origin,
+             struct si::ice_point>);
 static_assert(
-  is_of_type<quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>::absolute_point_origin,
+  is_of_type<quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>::absolute_point_origin,
              struct si::absolute_zero>);
-static_assert(unit_for<quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>> ==
+static_assert(unit_for<quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>> ==
               si::degree_Celsius);
-static_assert(reference_for<quantity_point<isq::Celsius_temperature[si::degree_Celsius], si::ice_point>> ==
-              isq::Celsius_temperature[si::degree_Celsius]);
+static_assert(reference_for<quantity_point<isq::thermodynamic_temperature[si::degree_Celsius], si::ice_point>> ==
+              isq::thermodynamic_temperature[si::degree_Celsius]);
 
 
 //////////////////