Skip to content

Commit d965383

Browse files
committed
fix: inplace_vector::push_back fixed
1 parent 2960d31 commit d965383

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/core/include/mp-units/ext/inplace_vector.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import std;
3333
#else
3434
#include <concepts>
3535
#include <cstddef>
36-
#include <ranges>
3736
#if MP_UNITS_HOSTED
3837
#include <stdexcept>
3938
#endif
@@ -99,14 +98,15 @@ class inplace_vector {
9998
return emplace_back(val);
10099
}
101100

102-
constexpr reference push_back(T&& val)
103-
requires std::constructible_from<T, T&&>
101+
template<typename U>
102+
requires std::constructible_from<T, U&&>
103+
constexpr reference push_back(U&& val)
104104
{
105-
return emplace_back(std::forward<T&&>(val));
105+
return emplace_back(std::forward<U>(val));
106106
}
107107

108108
template<typename... Args>
109-
requires(std::constructible_from<T, Args...>)
109+
requires std::constructible_from<T, Args...>
110110
constexpr T& unchecked_emplace_back(Args&&... args)
111111
{
112112
std::construct_at(end(), std::forward<Args>(args)...);
@@ -115,7 +115,7 @@ class inplace_vector {
115115
}
116116

117117
template<typename... Args>
118-
requires(std::constructible_from<T, Args...>)
118+
requires std::constructible_from<T, Args...>
119119
constexpr T* try_emplace_back(Args&&... args)
120120
{
121121
if (size() == capacity()) return nullptr;

0 commit comments

Comments
 (0)