Skip to content

[Docs]: cpp_compiler_support #761

@adah1972

Description

@adah1972

Documentation Type

Error/Inaccuracy in existing docs

Page URL

https://github.com/mpusz/mp-units/blob/master/docs/getting_started/cpp_compiler_support.md

Issue Description

It says:

MSVC still has a poor C++20 conformance. We had to make many workarounds to our codebase
to make it compile on this compiler. Usage of such nasty preprocessor macros degrade the
readability and maintainability of our code. This is why we've applied those patches to
the main library code but not to unit tests and examples. Those still do not compile on
MSVC.

As I just checked, the two issues reported have both been fixed. So this section should be updated or removed.

Location

Under ??? note "MSVC bugs".

Suggested Fix

A potential fix:

    MSVC had a poor C++20 conformance. We had to make many workarounds to our codebase
    to make it compile on this compiler. Usage of such nasty preprocessor macros degrade the
    readability and maintainability of our code. This is why we've applied those patches to
    the main library code but not to unit tests and examples.

    The most important MSVC bugs have been fixed:

    - [Syntax error when using non-type template parameters in templated class member function](https://developercommunity.visualstudio.com/t/Syntax-error-when-using-non-type-templat/10729428)
    - [Type always preferred over value when using qualified identifiers](https://developercommunity.visualstudio.com/t/Type-always-prefered-over-value-when-usi/10729382)

    Try updating your MSVC compiler if you encounter issues.

Additional Context

No response

Checklist

  • I have checked that this documentation issue doesn't already exist

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationDocumentation update requesttriageTriage a new issue

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions