Skip to content

Commit 3806d6f

Browse files
committed
command: don't update UPDATE_VIDEO options while changing file
When the current playlist entry changes, or when quitting, and file-local options values are reset, the VO re-renders the current file with the new option values before rendering the next file, if any, causing flicker. The previous commit fixed it for zoom/pan-related options. Fixing it for options with UPDATE_VIDEO, e.g. brightness/gamma/saturation/contrast, is much easier since we just have to ignore UPDATE_VIDEO when playback is quitting. The only reason that flag was added is for doing something no-osd add gamma 1 while paused (531868f), so even if we ignore it while quitting playback, the VO will update automatically on the next file.
1 parent a1b4ab3 commit 3806d6f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

player/command.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8072,7 +8072,7 @@ void mp_option_run_callback(struct MPContext *mpctx, struct mp_option_callback *
80728072
update_lavfi_complex(mpctx);
80738073

80748074
if (flags & UPDATE_VIDEO) {
8075-
if (mpctx->video_out) {
8075+
if (mpctx->video_out && !mpctx->stop_play) {
80768076
vo_control(mpctx->video_out, VOCTRL_UPDATE_RENDER_OPTS, NULL);
80778077
mp_wakeup_core(mpctx);
80788078
}

0 commit comments

Comments
 (0)