python: lint and avoid calling Py_FinalizeEx (see comment in the source file)

Author: 8lurry

TOOLS/python/acompressor.py

@@ -5,7 +5,6 @@
 # of the parameters.
 
 import re
-import typing
 from mpvclient import mpv  # type: ignore
 
 o = dict(
@@ -73,7 +72,7 @@ def show_osd(filter):  # noqa: A002
         mpv.commandv("show-text", "Dynamic range compressor: disabled", o["osd_timeout"])
         return
 
-    pretty: typing.Union[str, list] = []
+    pretty: str | list = []
     for param in params:
         value = parse_value(filter["params"][param["name"]])
         if not (param["hide_default"] and value == o["default_" + param["name"]]):  # type: ignore

player/main.c

@@ -213,9 +213,24 @@ void mp_destroy(struct MPContext *mpctx)
     uninit_libav(mpctx->global);
 
 #if HAVE_PYTHON
-    if (mpctx->opts->enable_python) {
-        if (Py_IsInitialized()) Py_FinalizeEx();
-    }
+    // Do NOT call Py_FinalizeEx() here.
+    //
+    // Subinterpreters use OWN_GIL + use_main_obmalloc=0, giving each script
+    // its own isolated pymalloc arena.  Py_EndInterpreter() (called per
+    // script in end_interpreter()) frees that arena.  However, Py_AtExit()
+    // handlers registered by C extension modules (e.g. _ssl via
+    // requests/urllib3) are invoked by Py_FinalizeEx() in the main
+    // interpreter's context.  If such a handler holds a reference to a
+    // Python object that lived in the now-freed subinterpreter arena and
+    // tries to Py_XDECREF / PyObject_Free it through the main allocator,
+    // glibc reports "free(): invalid pointer" and aborts.
+    //
+    // Skipping Py_FinalizeEx() is safe here: all script subinterpreters are
+    // already finalized by the time we reach this point, and the OS reclaims
+    // all remaining memory on process exit.
+    // if (mpctx->opts->enable_python) {
+    //     if (Py_IsInitialized()) Py_FinalizeEx();
+    // }
 #endif
 
     mp_msg_uninit(mpctx->global);

player/python/defaults.py

@@ -52,8 +52,8 @@ def typeconv(self, desttypeval, val):
                 val = None
         return val
 
-    def read_options(self, options: dict, identifier: typing.Optional[str] = None,
-        on_update: typing.Optional[typing.Callable[[typing.Any], typing.Any]] = None,
+    def read_options(self, options: dict, identifier: str | None = None,
+        on_update: typing.Callable[[typing.Any], typing.Any] | None = None,
     ):
         option_types = options.copy()