osc.lua: fix window controls showing in fullscreen

If `no-border` or `no-title-bar` was used, window controls would enable
also in fullscreen, this was inconsistent, as window decorations are not
visible ragardless of those options in fullscreen mode.

Author: kasper93

DOCS/man/osc.rst

@@ -404,7 +404,8 @@ Configurable Options
     render OSD into the unscaled video.
 
 ``windowcontrols``
-    Default: auto (Show window controls if there is no window border)
+    Default: auto (Show window controls if there is no window border/title-bar or
+    in the fullscreen mode.)
 
     Whether to show window management controls over the video, and if so,
     which side of the window to place them. This may be desirable when the
@@ -416,6 +417,12 @@ Configurable Options
     and ``quit``. Not all platforms implement ``minimize`` and ``maximize``,
     but ``quit`` will always work.
 
+``windowcontrols_fullscreen``
+    Default: no
+
+    Whether to show window controls in fullscreen mode. Only applies when
+    ``windowcontrols`` is set to ``auto``.
+
 ``windowcontrols_independent``
     Default: yes
 

player/lua/osc.lua

@@ -49,6 +49,7 @@ local user_opts = {
     boxmaxchars = 80,           -- title crop threshold for box layout
     boxvideo = false,           -- apply osc_param.video_margins to video
     windowcontrols = "auto",    -- whether to show window controls
+    windowcontrols_fullscreen = false, -- show window controls in fullscreen
     windowcontrols_alignment = "right", -- which side to show window controls on
     windowcontrols_title = "${media-title}", -- same as title but for windowcontrols
     windowcontrols_independent = true, -- show window controls and bottom bar independently
@@ -650,7 +651,10 @@ end
 local function window_controls_enabled()
     local val = user_opts.windowcontrols
     if val == "auto" then
-        return not (state.border and state.title_bar)
+        if state.fullscreen then
+            return user_opts.windowcontrols_fullscreen
+        end
+        return not state.border or not state.title_bar
     else
         return val ~= "no"
     end