fix!: run goroutine and goroutinederive checkers independently

BREAKING CHANGE: Previously, setting -goroutine-deriver would replace
the goroutine checker entirely. Now both checkers run independently,
allowing users to get both "context not propagated" and "deriver not
called" diagnostics simultaneously.

This is the intended behavior since the two checkers serve different
purposes:
- goroutine: ensures context is captured/used in goroutines
- goroutinederive: ensures specific deriver functions are called

Retract all previous versions (v0.1.1-v0.2.0) due to this bug.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: mpyw

analyzer.go

@@ -124,12 +124,12 @@ func runASTChecks(
 		goStmtCheckers []checkers.GoStmtChecker
 	)
 
-	// When goroutine-deriver is set, it replaces the base goroutine checker.
-	// The derive checker is a more specific version that checks for deriver function calls.
+	if enableGoroutine {
+		goStmtCheckers = append(goStmtCheckers, goroutine.New())
+	}
+
 	if goroutineDeriver != "" {
 		goStmtCheckers = append(goStmtCheckers, goroutinederive.New(goroutineDeriver))
-	} else if enableGoroutine {
-		goStmtCheckers = append(goStmtCheckers, goroutine.New())
 	}
 
 	if enableWaitgroup {

go.mod

@@ -2,6 +2,10 @@ module github.com/mpyw/goroutinectx
 
 go 1.24.0
 
+// Retract all previous versions due to a bug where -goroutine-deriver flag
+// incorrectly disabled the base goroutine checker instead of running both independently.
+retract [v0.1.1, v0.2.0]
+
 require golang.org/x/tools v0.40.0
 
 require (

testdata/src/goroutinederiveand/evil.go

@@ -67,7 +67,7 @@ func badAndNested2LevelInnerMissingOneDeriver(ctx context.Context, txn *newrelic
 //
 // AND - both derivers in nested IIFE (not at outer level).
 func goodAndBothDeriverInNestedIIFE(ctx context.Context, txn *newrelic.Transaction) {
-	go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context"
+	go func() { // want `goroutine does not propagate context "ctx"` `goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context`
 		func() {
 			txn = txn.NewGoroutine()
 			ctx = newrelic.NewContext(ctx, txn)
@@ -80,7 +80,7 @@ func goodAndBothDeriverInNestedIIFE(ctx context.Context, txn *newrelic.Transacti
 //
 // AND - split derivers across levels (outer has first, IIFE has second).
 func goodAndSplitDeriversAcrossLevels(ctx context.Context, txn *newrelic.Transaction) {
-	go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context"
+	go func() { // want `goroutine does not propagate context "ctx"` `goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context`
 		txn = txn.NewGoroutine() // First deriver at outer level
 		func() {
 			ctx = newrelic.NewContext(ctx, txn) // Second deriver in IIFE - not counted for outer
@@ -94,7 +94,7 @@ func goodAndSplitDeriversAcrossLevels(ctx context.Context, txn *newrelic.Transac
 //
 // AND - nested 3-level, outer only has first deriver.
 func badAndNested3LevelOuterPartial(ctx context.Context, txn *newrelic.Transaction) {
-	go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context"
+	go func() { // want `goroutine does not propagate context "ctx"` `goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context`
 		txn = txn.NewGoroutine() // Only first deriver
 		go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext to derive context"
 			ctx = newrelic.NewContext(ctx, txn) // Only second deriver

testdata/src/goroutinederivemixed/evil.go

@@ -64,7 +64,7 @@ func goodMixedNested2LevelInnerSatisfiesNeither(ctx context.Context, txn *newrel
 //
 // IIFE pattern with AND group deriver requirements.
 func goodMixedSplitDeriversAcrossLevels(ctx context.Context, txn *newrelic.Transaction) {
-	go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context"
+	go func() { // want `goroutine does not propagate context "ctx"` `goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context`
 		txn = txn.NewGoroutine() // Only first of AND
 		func() {
 			ctx = newrelic.NewContext(ctx, txn) // Second of AND in IIFE - doesn't count
@@ -78,7 +78,7 @@ func goodMixedSplitDeriversAcrossLevels(ctx context.Context, txn *newrelic.Trans
 //
 // Satisfies the mixed requirement via OR alternative path.
 func goodMixedOrAlternativeInNestedIIFE(ctx context.Context) {
-	go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context"
+	go func() { // want `goroutine does not propagate context "ctx"` `goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context`
 		func() {
 			ctx = apm.NewGoroutineContext(ctx)
 			_ = ctx
@@ -90,7 +90,7 @@ func goodMixedOrAlternativeInNestedIIFE(ctx context.Context) {
 //
 // Nested pattern where outer only calls first deriver of AND group.
 func badMixedNested3LevelOuterPartial(ctx context.Context, txn *newrelic.Transaction) {
-	go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context"
+	go func() { // want `goroutine does not propagate context "ctx"` `goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context`
 		txn = txn.NewGoroutine() // Only first of AND
 		go func() { // want "goroutine should call github.com/newrelic/go-agent/v3/newrelic.Transaction.NewGoroutine\\+github.com/newrelic/go-agent/v3/newrelic.NewContext,github.com/my-example-app/telemetry/apm.NewGoroutineContext to derive context"
 			ctx = newrelic.NewContext(ctx, txn) // Only second of AND