Skip to content

What would it take to add a py.typed ? #48

@RobLevv

Description

@RobLevv

I was wondering how much work would it take to add typing for this library with a py.typed file to tell mypy that it is possible to type check this library.
If you are open to it, I could provide you with a PR.

TL;DR

Hi, I have been using this tool for some time now in various projects. So first of all, thank you!

Recently, I came to improve the typing of all of my projects and I realized some of the libraries I have been using where still lacking some infos for type checkers (mypy essentially) to completely do their jobs. Until now, I was ignoring the warnings telling me that type checking specific dependencies as this one was impossible, but I would like this to change because ignoring some errors can sometimes hide real bugs.

I looked a bit at the code and it seems to be typed in some place while mostly being untyped, there is even some mypy configuration, so there must already be some consistency almost everywhere.

Did you already tried and did not succeed so much so the idea was abandonned or did you just never have the time to do such work ?
Are there some impossibilities/magic tricks in the code that would make typing very difficult ?

Thank you for your time and your work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions