fix: _storeProcessing staying true after outStore got emptied (#1492)

Genoil · janwillem-penterman · robertsLando · web-flow · commit f3f7be761991 · 2023-06-28T17:33:31.000+02:00
Co-authored-by: Jan Willem Penterman &lt;janwillem@gingeros.ai&gt;
Co-authored-by: Daniel Lando &lt;daniel.sorridi@gmail.com&gt;
diff --git a/lib/client.js b/lib/client.js
@@ -1817,7 +1817,6 @@ MqttClient.prototype._onConnect = function (packet) {
       if (!outStore) {
         return
       }
-      that._storeProcessing = true
 
       const packet = outStore.read(1)
 
@@ -1829,6 +1828,8 @@ MqttClient.prototype._onConnect = function (packet) {
         return
       }
 
+      that._storeProcessing = true
+
       // Skip already processed store packets
       if (that._packetIdsDuringStoreProcessing[packet.messageId]) {
         storeDeliver()

Original file line number	Diff line number	Diff line change
`@@ -1817,7 +1817,6 @@ MqttClient.prototype._onConnect = function (packet) {`
`1817`	`1817`	`if (!outStore) {`
`1818`	`1818`	`return`
`1819`	`1819`	`}`
`1820`		`- that._storeProcessing = true`
`1821`	`1820`
`1822`	`1821`	`const packet = outStore.read(1)`
`1823`	`1822`
`@@ -1829,6 +1828,8 @@ MqttClient.prototype._onConnect = function (packet) {`
`1829`	`1828`	`return`
`1830`	`1829`	`}`
`1831`	`1830`
	`1831`	`+ that._storeProcessing = true`
	`1832`	`+`
`1832`	`1833`	`// Skip already processed store packets`
`1833`	`1834`	`if (that._packetIdsDuringStoreProcessing[packet.messageId]) {`
`1834`	`1835`	`storeDeliver()`