Skip to content

Commit 1885346

Browse files
committed
improve inspector message
1 parent f89095b commit 1885346

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

examples/jsm/inspector/Inspector.js

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class Inspector extends RendererInspector {
110110

111111
}
112112

113-
resolveConsole( type, message ) {
113+
resolveConsole( type, message, stackTrace = null ) {
114114

115115
switch ( type ) {
116116

@@ -126,15 +126,31 @@ class Inspector extends RendererInspector {
126126

127127
this.console.addMessage( 'warn', message );
128128

129-
console.warn( message );
129+
if ( stackTrace && stackTrace.isStackTrace ) {
130+
131+
console.warn( stackTrace.getError( message ) );
132+
133+
} else {
134+
135+
console.warn( message );
136+
137+
}
130138

131139
break;
132140

133141
case 'error':
134142

135143
this.console.addMessage( 'error', message );
136144

137-
console.error( message );
145+
if ( stackTrace && stackTrace.isStackTrace ) {
146+
147+
console.error( stackTrace.getError( message ) );
148+
149+
} else {
150+
151+
console.error( message );
152+
153+
}
138154

139155
break;
140156

src/nodes/core/StackTrace.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ class StackTrace {
9090
const mainStack = this.stack[ 0 ];
9191

9292
const fn = mainStack.fn;
93-
const fnName = fn ? `${ fn }() at ` : '';
93+
const fnName = fn ? `"${ fn }()" at ` : '';
9494

95-
return `${fnName}${mainStack.file}:${mainStack.line}`; // :${mainStack.column}
95+
return `${fnName}"${mainStack.file}:${mainStack.line}"`; // :${mainStack.column}
9696

9797
}
9898

0 commit comments

Comments
 (0)