Skip to content

Commit 6320341

Browse files
authored
BindGroup: Remove bindingsReference. (#32910)
1 parent 3ea832d commit 6320341

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

src/nodes/core/NodeBuilder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -598,15 +598,15 @@ class NodeBuilder {
598598

599599
if ( bindGroup === undefined ) {
600600

601-
bindGroup = new BindGroup( groupName, bindingsArray, this.bindingsIndexes[ groupName ].group, bindingsArray );
601+
bindGroup = new BindGroup( groupName, bindingsArray, this.bindingsIndexes[ groupName ].group );
602602

603603
bindGroupsCache.set( bindingsArray, bindGroup );
604604

605605
}
606606

607607
} else {
608608

609-
bindGroup = new BindGroup( groupName, bindingsArray, this.bindingsIndexes[ groupName ].group, bindingsArray );
609+
bindGroup = new BindGroup( groupName, bindingsArray, this.bindingsIndexes[ groupName ].group );
610610

611611
}
612612

src/renderers/common/BindGroup.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,8 @@ class BindGroup {
1515
* @param {string} name - The bind group's name.
1616
* @param {Array<Binding>} bindings - An array of bindings.
1717
* @param {number} index - The group index.
18-
* @param {Array<Binding>} bindingsReference - An array of reference bindings.
1918
*/
20-
constructor( name = '', bindings = [], index = 0, bindingsReference = [] ) {
19+
constructor( name = '', bindings = [], index = 0 ) {
2120

2221
/**
2322
* The bind group's name.
@@ -40,13 +39,6 @@ class BindGroup {
4039
*/
4140
this.index = index;
4241

43-
/**
44-
* An array of reference bindings.
45-
*
46-
* @type {Array<Binding>}
47-
*/
48-
this.bindingsReference = bindingsReference;
49-
5042
/**
5143
* The group's ID.
5244
*

src/renderers/common/nodes/NodeBuilderState.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class NodeBuilderState {
126126

127127
if ( shared !== true ) {
128128

129-
const bindingsGroup = new BindGroup( instanceGroup.name, [], instanceGroup.index, instanceGroup.bindingsReference );
129+
const bindingsGroup = new BindGroup( instanceGroup.name, [], instanceGroup.index );
130130
bindings.push( bindingsGroup );
131131

132132
for ( const instanceBinding of instanceGroup.bindings ) {

0 commit comments

Comments
 (0)