add hot reload and some other stuff i guess

Author: mrf7

app/build.gradle.kts

@@ -8,6 +8,7 @@ plugins {
     alias(libs.plugins.kotlin.multiplatform)
     alias(libs.plugins.compose.runtime)
     alias(libs.plugins.compose.compiler)
+    id("org.jetbrains.compose.hot-reload") version "1.0.0-alpha10" // <- add this additionally
 }
 
 group = "com.mfriend"

app/src/commonMain/kotlin/App.kt

@@ -9,8 +9,8 @@ import androidx.compose.runtime.setValue
 import org.jetbrains.compose.ui.tooling.preview.Preview
 
 expect val Platform: String
+
 @Composable
-@Preview
 fun App() {
     var text by remember { mutableStateOf("Hello, World!") }
 
@@ -22,3 +22,9 @@ fun App() {
         }
     }
 }
+
+@Preview
+@Composable
+fun AppPreview() {
+    App()
+}

app/src/desktopMain/kotlin/Main.kt

@@ -1,5 +1,3 @@
-import androidx.compose.runtime.getValue
-import androidx.compose.runtime.setValue
 import androidx.compose.ui.window.Window
 import androidx.compose.ui.window.application
 

docs/tasks.md

@@ -0,0 +1,113 @@
+# KMMtg Improvement Tasks
+
+This document contains a prioritized list of actionable improvement tasks for the KMMtg project. Each task is designed to enhance the project's architecture, code quality, or functionality.
+
+## Architecture Improvements
+
+1. [ ] Complete Android support in all modules
+   - Fix Android configuration in scryfall module
+   - Uncomment and fix Android-specific code in build.gradle.kts files
+   - Implement Android-specific database drivers
+
+2. [ ] Implement proper multiplatform support for collection-import module
+   - Research alternatives to kotlin-csv that support iOS
+   - Implement iOS-specific file handling
+
+3. [ ] Implement a proper dependency injection framework across all modules
+   - Standardize Koin usage across all modules
+   - Create module definitions for each module
+
+4. [ ] Implement a comprehensive error handling strategy
+   - Standardize error types and handling across modules
+   - Improve error messages and logging
+
+5. [ ] Implement a proper user authentication and authorization system
+   - Complete User table implementation
+   - Add password/authentication fields
+   - Implement token-based authentication
+
+## Database Improvements
+
+6. [ ] Enhance Card schema with additional attributes
+   - Add mana cost, card type, rarity, and other important MTG card attributes
+   - Update queries to support filtering by these attributes
+
+7. [ ] Complete User-Deck relationship implementation
+   - Uncomment and implement user_id foreign key in Deck table
+   - Implement user-specific deck queries
+
+8. [ ] Add query to update card quantity in a deck
+   - Implement updateCardQuantityInDeck query in DeckCard.sq
+
+9. [ ] Implement database migrations strategy
+   - Add versioning to database schema
+   - Create migration scripts for future schema changes
+
+## API Improvements
+
+10. [ ] Expand Scryfall API coverage
+    - Implement additional endpoints (card by ID, random card, etc.)
+    - Add support for advanced search parameters
+
+11. [ ] Implement pagination handling for Scryfall API responses
+    - Add support for retrieving multiple pages of results
+    - Implement a paging mechanism for large result sets
+
+12. [ ] Add caching for Scryfall API responses
+    - Implement a caching strategy to reduce API calls
+    - Add TTL (time-to-live) for cached responses
+
+## Testing and Documentation
+
+13. [ ] Implement comprehensive unit tests for all modules
+    - Add tests for database operations
+    - Add tests for API client
+    - Add tests for collection import/export
+
+14. [ ] Implement integration tests
+    - Add tests for interactions between modules
+    - Add end-to-end tests for key user flows
+
+15. [ ] Add KDoc documentation to all public APIs
+    - Document all public classes, interfaces, and functions
+    - Include examples where appropriate
+
+16. [ ] Create user documentation
+    - Add usage examples for CLI
+    - Document supported file formats for collection import/export
+
+## Code Quality Improvements
+
+17. [ ] Replace non-null assertions (!!) with proper null handling
+    - Use Elvis operator (?:) or other null-safe approaches
+    - Add validation to prevent null pointer exceptions
+
+18. [ ] Implement proper logging throughout the application
+    - Standardize logging approach
+    - Add appropriate log levels for different types of messages
+
+19. [ ] Add input validation for all user inputs
+    - Validate CSV file formats
+    - Validate deck construction rules
+
+20. [ ] Implement proper exception handling
+    - Replace generic error messages with specific ones
+    - Add context to error messages
+
+## Feature Improvements
+
+21. [ ] Add support for additional collection import/export formats
+    - Support more popular MTG collection management tools
+    - Implement a plugin system for custom formats
+
+22. [ ] Implement deck validation against format rules
+    - Add support for checking deck legality in different formats
+    - Implement card legality checking
+
+23. [ ] Add support for card pricing information
+    - Integrate with pricing APIs
+    - Add price tracking for collections
+
+24. [ ] Enhance CLI with more interactive features
+    - Implement autocomplete for card names
+    - Add visual card representation in terminal

gradle/libs.versions.toml

@@ -1,5 +1,5 @@
 [versions]
-kotlin = "2.2.0-RC"
+kotlin = "2.2.0"
 kermit = "2.0.5"
 arrow = "2.1.1"
 koin = "4.0.3"

scryfall/src/commonMain/kotlin/client/ScryfallApi.kt

@@ -31,7 +31,9 @@ interface ScryfallApi : AutoCloseable {
     suspend fun setsRaise(): List<SetDto>
 }
 
-class ScryfallApiImpl : ScryfallApi, AutoCloseable {
+class ScryfallApiImpl :
+    ScryfallApi,
+    AutoCloseable {
     private val client = newKtorClient()
 
     context(_: Raise<ScryfallError>)
@@ -44,38 +46,33 @@ class ScryfallApiImpl : ScryfallApi, AutoCloseable {
     }
 
     context(_: Raise<InvalidResponse>)
-    private suspend inline fun <reified T> HttpResponse.bodyOrError(): T =
-        catch({ body<T>() }) { t: ContentConvertException ->
-            raise(InvalidResponse(body<String>(), T::class.simpleName ?: "unknown class", t))
-        }
+    private suspend inline fun <reified T> HttpResponse.bodyOrError(): T = catch({ body<T>() }) { t: ContentConvertException ->
+        raise(InvalidResponse(body<String>(), T::class.simpleName ?: "unknown class", t))
+    }
 
     /**
      * Gets a single card object from the search or raises a [ScryfallErrorResponse]
      * If the error response doesnt fit [ScryfallErrorResponse] throws an exception
      */
-    context(_: Raise<ScryfallError>) override suspend fun cardNamedRaise(name: String): CardDto {
-        return client.get {
-            scryfall("$CardApiBase$FindNamed")
-            parameter("fuzzy", name)
-        }.responseBodyOrRaise()
-    }
-
+    context(_: Raise<ScryfallError>)
+    override suspend fun cardNamedRaise(name: String): CardDto = client.get {
+        scryfall("$CardApiBase$FindNamed")
+        parameter("fuzzy", name)
+    }.responseBodyOrRaise()
 
     // This NEEDS to be called or it will hold up the couroutine scope of suspend fun main
     override fun close() {
         client.close()
     }
 
     context(_: Raise<ScryfallError>)
-    override suspend fun searchCardRaise(searchParam: String): List<CardDto> =
-        client.get {
-            scryfall("$CardApiBase$Search")
-            parameter("q", searchParam)
-        }.responseBodyOrRaise<ListResp<CardDto>>().data
+    override suspend fun searchCardRaise(searchParam: String): List<CardDto> = client.get {
+        scryfall("$CardApiBase$Search")
+        parameter("q", searchParam)
+    }.responseBodyOrRaise<ListResp<CardDto>>().data
 
     context(_: Raise<ScryfallError>)
-    override suspend fun setsRaise(): List<SetDto> =
-        client.get { scryfall("sets") }.responseBodyOrRaise<ListResp<SetDto>>().data
+    override suspend fun setsRaise(): List<SetDto> = client.get { scryfall("sets") }.responseBodyOrRaise<ListResp<SetDto>>().data
 
     companion object {
         const val ScryfallBaseUri: String = "https://api.scryfall.com"