Update lints

Signed-off-by: Maxime Ripard <mripard@kernel.org>

Author: mripard

.rustfmt.toml

@@ -1,4 +1,7 @@
 unstable_features = true
 
 comment_width = 100
+group_imports = "StdExternalCrate"
+imports_granularity = "Crate"
+style_edition = "2024"
 wrap_comments = true

Cargo.toml

@@ -22,12 +22,12 @@ nightly = []
 [lints.rust]
 # Groups
 future_incompatible = { level = "warn", priority = -1 }
+keyword_idents = { level = "warn", priority = -1 }
 nonstandard_style = { level = "warn", priority = -1 }
 rust_2018_idioms = { level = "warn", priority = -1 }
 
 # Individual Lints
 absolute_paths_not_starting_with_crate = "warn"
-keyword_idents = "warn"
 let_underscore_drop = "warn"
 macro_use_extern_crate = "warn"
 missing_abi = "deny"
@@ -42,7 +42,7 @@ single_use_lifetimes = "warn"
 trivial_casts = "warn"
 trivial_numeric_casts = "warn"
 unreachable_pub = "warn"
-# unsafe_code = "deny"
+unsafe_code = "deny"
 unsafe_op_in_unsafe_fn = "warn"
 unused_crate_dependencies = "warn"
 unused_import_braces = "warn"
@@ -65,6 +65,7 @@ suspicious = { level = "warn", priority = -1 }
 # Individual Lints
 ## Restriction Clippy Lints
 alloc_instead_of_core = "warn"
+as_pointer_underscore = "warn"
 assertions_on_result_states = "warn"
 dbg_macro = "warn"
 decimal_literal_representation = "warn"
@@ -79,6 +80,7 @@ get_unwrap = "warn"
 infinite_loop = "warn"
 let_underscore_must_use = "warn"
 let_underscore_untyped = "warn"
+literal_string_with_formatting_args = "warn"
 lossy_float_literal = "warn"
 map_err_ignore = "warn"
 mem_forget = "warn"
@@ -92,8 +94,10 @@ multiple_unsafe_ops_per_block = "warn"
 mutex_atomic = "warn"
 needless_raw_strings = "warn"
 non_ascii_literal = "warn"
+non_zero_suggestions = "warn"
 panic_in_result_fn = "warn"
 partial_pub_fields = "warn"
+pathbuf_init_then_push = "warn"
 print_stdout = "warn"
 redundant_type_annotations = "warn"
 ref_patterns = "warn"
@@ -115,6 +119,8 @@ unnecessary_safety_comment = "warn"
 unnecessary_safety_doc = "warn"
 unnecessary_self_imports = "warn"
 unneeded_field_pattern = "warn"
+unused_result_ok = "warn"
+unused_trait_names = "warn"
 unwrap_in_result = "warn"
 unwrap_used = "warn"
 use_debug = "warn"

src/ioctl.rs

@@ -1,12 +1,12 @@
 use std::{
     io,
-    os::fd::{BorrowedFd, FromRawFd, OwnedFd, RawFd},
+    os::fd::{BorrowedFd, FromRawFd as _, OwnedFd, RawFd},
 };
 
 use rustix::{
     fs::OFlags,
     io::Errno,
-    ioctl::{ioctl, opcode, Updater},
+    ioctl::{Updater, ioctl, opcode},
 };
 
 use crate::{HeapError, Result};
@@ -32,7 +32,8 @@ fn dma_heap_alloc_ioctl(
 ) -> core::result::Result<(), Errno> {
     // SAFETY: This function is unsafe because the opcode has to be valid, and the value type must
     // match. We have checked those, so we're good.
-    let ioctl_type = unsafe { Updater::<DMA_HEAP_IOC_ALLOC_OPCODE, dma_heap_allocation_data>::new(data) };
+    let ioctl_type =
+        unsafe { Updater::<DMA_HEAP_IOC_ALLOC_OPCODE, dma_heap_allocation_data>::new(data) };
 
     // SAFETY: This function is unsafe because the driver isn't guaranteed to implement the ioctl,
     // and to implement it properly. We don't have much of a choice and still have to trust the

src/lib.rs

@@ -21,16 +21,16 @@
     )
 )]
 #![doc = include_str!("../README.md")]
+#![allow(unsafe_code)]
 
 use std::{
     fs::File,
-    os::{fd::AsFd, unix::io::OwnedFd},
+    os::{fd::AsFd as _, unix::io::OwnedFd},
     path::PathBuf,
 };
 
 mod ioctl;
 use ioctl::dma_heap_alloc;
-
 use log::debug;
 use strum_macros::Display;