Skip to content

Commit d5bc86e

Browse files
jsjmrjsj
authored andcommitted
improve unit tests
1 parent e335ed4 commit d5bc86e

File tree

2 files changed

+49
-12
lines changed

2 files changed

+49
-12
lines changed

tests/internal/fabric_api/test_lakehouse.py

Lines changed: 36 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,32 +16,56 @@ def test_get_workspace_lakehouses():
1616
assert isinstance(lakehouses, list)
1717
assert len(lakehouses) > 0
1818

19+
lakehouse = [lakehouse for lakehouse in lakehouses if lakehouse["id"] == LAKEHOUSE_ID]
20+
21+
assert len(lakehouse) == 1
22+
assert isinstance(lakehouse[0], dict)
23+
assert lakehouse[0]["displayName"] == LAKEHOUSE_NAME
24+
assert lakehouse[0]["id"] == LAKEHOUSE_ID
25+
1926
def test_get_workspace_lakehouses_by_id():
2027
lakehouses = get_workspace_lakehouses(workspace_id=WORKSPACE_ID)
2128
assert isinstance(lakehouses, list)
2229
assert len(lakehouses) > 0
2330

31+
lakehouse = [lakehouse for lakehouse in lakehouses if lakehouse["id"] == LAKEHOUSE_ID]
32+
33+
assert len(lakehouse) == 1
34+
assert isinstance(lakehouse[0], dict)
35+
assert lakehouse[0]["displayName"] == LAKEHOUSE_NAME
36+
assert lakehouse[0]["id"] == LAKEHOUSE_ID
37+
2438
def test_get_workspace_lakehouses_by_name():
2539
lakehouses = get_workspace_lakehouses(workspace_name=WORKSPACE_NAME)
2640
assert isinstance(lakehouses, list)
2741
assert len(lakehouses) > 0
2842

43+
lakehouse = [lakehouse for lakehouse in lakehouses if lakehouse["id"] == LAKEHOUSE_ID]
44+
45+
assert len(lakehouse) == 1
46+
assert isinstance(lakehouse[0], dict)
47+
assert lakehouse[0]["displayName"] == LAKEHOUSE_NAME
48+
assert lakehouse[0]["id"] == LAKEHOUSE_ID
49+
2950
def test_get_workspace_lakehouse_tables_by_workspace_id_and_lakehouse_id():
30-
lakehouse = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_id=LAKEHOUSE_ID)
31-
assert isinstance(lakehouse, list)
32-
assert len(lakehouse) > 0
51+
tables = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_id=LAKEHOUSE_ID)
52+
assert isinstance(tables, list)
53+
assert len(tables) > 0
54+
3355

3456
def test_get_workspace_lakehouse_tables_by_workspace_id_and_lakehouse_name():
35-
lakehouse = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_name=LAKEHOUSE_NAME)
36-
assert isinstance(lakehouse, list)
37-
assert len(lakehouse) > 0
57+
tables = get_workspace_lakehouse_tables(workspace_id=WORKSPACE_ID, lakehouse_name=LAKEHOUSE_NAME)
58+
assert isinstance(tables, list)
59+
assert len(tables) > 0
60+
3861

3962
def test_get_workspace_lakehouse_tables_by_workspace_name_and_lakehouse_id():
40-
lakehouse = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_id=LAKEHOUSE_ID)
41-
assert isinstance(lakehouse, list)
42-
assert len(lakehouse) > 0
63+
tables = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_id=LAKEHOUSE_ID)
64+
assert isinstance(tables, list)
65+
assert len(tables) > 0
66+
4367

4468
def test_get_workspace_lakehouse_tables_by_workspace_name_and_lakehouse_name():
45-
lakehouse = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_name=LAKEHOUSE_NAME)
46-
assert isinstance(lakehouse, list)
47-
assert len(lakehouse) > 0
69+
tables = get_workspace_lakehouse_tables(workspace_name=WORKSPACE_NAME, lakehouse_name=LAKEHOUSE_NAME)
70+
assert isinstance(tables, list)
71+
assert len(tables) > 0

tests/internal/fabric_api/test_workspace.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,27 @@ def test_get_workspaces():
1515
assert len(workspaces) > 0
1616
assert isinstance(workspaces, list)
1717

18+
workspace = [workspace for workspace in workspaces if workspace["id"] == WORKSPACE_ID]
19+
20+
assert len(workspace) == 1
21+
assert isinstance(workspace[0], dict)
22+
assert workspace[0]["displayName"] == WORKSPACE_NAME
23+
assert workspace[0]["id"] == WORKSPACE_ID
24+
1825
def test_get_workspace_by_id():
1926
workspace = get_workspace(workspace_id=WORKSPACE_ID)
2027

2128
assert isinstance(workspace, dict)
2229
assert workspace is not None
2330

31+
assert workspace["displayName"] == WORKSPACE_NAME
32+
assert workspace["id"] == WORKSPACE_ID
33+
2434
def test_get_workspace_by_name():
2535
workspace = get_workspace(workspace_name=WORKSPACE_NAME)
2636

2737
assert isinstance(workspace, dict)
2838
assert workspace is not None
39+
40+
assert workspace["displayName"] == WORKSPACE_NAME
41+
assert workspace["id"] == WORKSPACE_ID

0 commit comments

Comments
 (0)