Skip to content

Commit 220efa6

Browse files
authored
Add wb-auth simcore service (ITISFoundation#1146)
* Add wb-auth simcore service * closes ITISFoundation#1145 * ITISFoundation/osparc-simcore#8130 * Rename env to follow existing style * Update PR templates (add grafana dashboards check) * Add public network
1 parent 9e04975 commit 220efa6

File tree

2 files changed

+30
-1
lines changed

2 files changed

+30
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@
1919
- [ ] Service is restartable
2020
- [ ] Service restart is zero-downtime
2121
- [ ] Service has >1 replicas in PROD
22-
- [ ] Service has docker heathlcheck enabled
22+
- [ ] Service has docker healthcheck enabled
2323
- [ ] Service is monitored (via prometheus and grafana)
2424
- [ ] Service is not bound to one specific node (e.g. via files or volumes)
2525
- [ ] Relevant OPS E2E Test are added
26+
- [ ] Grafana dashboards updated accordingly
2627
2728
If exposed via traefik
2829
- [ ] Service's Public URL is included in maintenance mode

services/simcore/docker-compose.yml.j2

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,34 @@ services:
337337
cpus: "1.0"
338338
memory: "512M"
339339
340+
wb-auth:
341+
networks:
342+
- monitored # traces
343+
- public # public service use auth
344+
deploy:
345+
replicas: ${WB_AUTH_REPLICAS}
346+
update_config:
347+
parallelism: 2
348+
order: start-first
349+
failure_action: rollback
350+
delay: 10s
351+
restart_policy:
352+
condition: any
353+
delay: 5s
354+
max_attempts: 3
355+
window: 120s
356+
placement:
357+
constraints:
358+
- node.labels.simcore==true
359+
resources:
360+
reservations:
361+
cpus: "0.1"
362+
memory: "256M"
363+
limits:
364+
cpus: "1"
365+
memory: "1G"
366+
# healthcheck: defined in image
367+
340368
storage:
341369
environment:
342370
- S3_ENDPOINT=${S3_ENDPOINT}

0 commit comments

Comments
 (0)